From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dave Page <dpage@pgadmin.org>
cc: Andrew Dunstan <andrew@dunslane.net>, Andres Freund <andres@anarazel.de>,
        pgsql-hackers@postgresql.org
Subject: Re: tests fail on windows with default git settings
In-reply-to: <CA+OCxoxL4=C3ZNu-KtyJ6FTqhL=-eEizN++unGu3AUKEiejK-g@mail.gmail.com>
References: <20240707052030.r77hbdkid3mwksop@awork3.anarazel.de> <625384.1720329973@sss.pgh.pa.us> <e006b6a2-2f8e-4463-a58e-09cd51280432@dunslane.net> <20240708201649.qaqllje7vc7eyiix@awork3.anarazel.de> <a49418d3-83ea-42bf-a356-2a057839c2e0@dunslane.net> <20240708214421.fxunxj2i34faoxq3@awork3.anarazel.de> <CA+OCxowFXZR8r=FLK5LY2AcN_4Nq1U7k7jQOpSe0_gePCLPekw@mail.gmail.com> <68d948a3-704a-4a0e-a7c9-0591f4ade7ce@dunslane.net> <9b08e271-5ae9-4bf2-b328-9123fceb7b98@dunslane.net> <CA+OCxoxL4=C3ZNu-KtyJ6FTqhL=-eEizN++unGu3AUKEiejK-g@mail.gmail.com>
Comments: In-reply-to Dave Page <dpage@pgadmin.org>
	message dated "Wed, 10 Jul 2024 12:17:50 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1732389.1720617925.1@sss.pgh.pa.us>
Date: Wed, 10 Jul 2024 09:25:25 -0400
Message-ID: <1732390.1720617925@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1732390.1720617925%40sss.pgh.pa.us>
Precedence: bulk

Dave Page <dpage@pgadmin.org> writes:
> On Wed, 10 Jul 2024 at 12:12, Andrew Dunstan <andrew@dunslane.net> wrote:
>> As I was looking at this I wondered if there might be anywhere else that
>> needed adjustment. One thing that occurred to me was that that maybe we
>> should replace the use of "-w" in pg_regress.c with this rather less
>> dangerous flag, so instead of ignoring any white space difference we would
>> only ignore line end differences. The use of "-w" apparently dates back to
>> 2009.

> That seems like a good improvement to me.

+1

			regards, tom lane