Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTkIV-0002in-KC for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Jun 2018 08:41:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fTkIT-0005RF-Lp for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Jun 2018 08:41:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTkIT-0005R3-Ei for pgsql-hackers@lists.postgresql.org; Fri, 15 Jun 2018 08:41:29 +0000 Received: from mx1.mailbox.org ([80.241.60.212]) by magus.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fTkIQ-0008Ti-3q for pgsql-hackers@postgresql.org; Fri, 15 Jun 2018 08:41:28 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 3966C4445A; Fri, 15 Jun 2018 10:41:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id n-H43d1Zi_2w; Fri, 15 Jun 2018 10:41:22 +0200 (CEST) From: Antonin Houska To: Tatsuo Ishii cc: thomas.munro@enterprisedb.com, pgsql-hackers@postgresql.org Subject: Re: Memory leaks in BufFileOpenShared() In-reply-to: <20180615.172208.29879168502273778.t-ishii@sraoss.co.jp> References: <11329.1529045692@localhost> <20180615.162003.2258832502225295119.t-ishii@sraoss.co.jp> <16139.1529049566@localhost> <20180615.172208.29879168502273778.t-ishii@sraoss.co.jp> Comments: In-reply-to Tatsuo Ishii message dated "Fri, 15 Jun 2018 17:22:08 +0900." MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 15 Jun 2018 10:42:33 +0200 Message-ID: <17325.1529052153@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Tatsuo Ishii wrote: > The changes were made by this commit to add infrastructure for sharing > temporary files between backends, according to the author (Thomas > Munro). >=20 > https://git.postgresql.org/pg/commitdiff/dc6c4c9dc2a111519b76b22daaaac86c= 5608223b >=20 > Your proposal looks reasonable but I would like to hear from Thomas's > opinion as well. o.k. He can actually have different feeling about details, e.g. if a new function makeBufFileCommon() should be introduced or if makeBufFile() should do the common settings. In the latter case, BufFileCreateTemp() would have = to do more work than it does now. --=20 Antonin Houska Cybertec Sch=C3=B6nig & Sch=C3=B6nig GmbH Gr=C3=B6hrm=C3=BChlgasse 26, A-2700 Wiener Neustadt Web: https://www.cybertec-postgresql.com