From: =?ISO-8859-1?Q?C=E9dric?= Villemain <cedric@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Reply-To: cedric@2ndquadrant.com
Cc: Andrew Dunstan <andrew@dunslane.net>, Josh Berkus <josh@agliodbs.com>,
 Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter_e@gmx.net>,
 Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Tue, 03 Sep 2013 10:04:06 +0200
Message-ID: <1739933.FyLmpy7Q73@obelix>
Organization: 2ndQuadrant France
User-Agent: KMail/4.10.5 (Linux/3.10-2-rt-amd64; KDE/4.10.5; x86_64; ; )
In-Reply-To: <201307122350.23726.cedric@2ndquadrant.com>
References: <201306181552.36673.cedric@2ndquadrant.com>
 <51DB171F.2090108@dunslane.net> <201307122350.23726.cedric@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1693598.58uvEAtsm9";
 micalg="pgp-sha1"; protocol="application/pgp-signature"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--nextPart1693598.58uvEAtsm9
Content-Type: multipart/mixed; boundary="nextPart1504425.HPg8ZNtvSs"
Content-Transfer-Encoding: 7Bit

This is a multi-part message in MIME format.

--nextPart1504425.HPg8ZNtvSs
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

> Simple one, attached.
> I didn't document USE_VPATH, not sure how to explain that clearly.

Just a remember that the doc is written and is waiting to be commited.

There is also an issue spoted by Christoph with the installdirs prerequ=
isite,=20
the attached patch fix that.

Also, the bugfixes were supposed to be backported. The behavior is not =
changed,=20
nothing new, just fixing problem for some kind of extension builds. (Ho=
wever=20
the USE_VPATH is new and is not needed in <9.3)

--=20
C=E9dric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - D=E9veloppement, Expertise et Formation
--nextPart1504425.HPg8ZNtvSs
Content-Disposition: attachment; filename="0001-Add-installdirs-to-PGXS-order-only-prerequisites.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="utf-8"; name="0001-Add-installdirs-to-PGXS-order-only-prerequisites.patch"

From fb9d5ed99397b40e7fc33224fa31cd5c54c7b5d2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Villemain?= <cedric@2ndquadrant.fr>
Date: Tue, 3 Sep 2013 09:55:05 +0200
Subject: [PATCH] Add installdirs to PGXS order-only-prerequisites

prerequisites are not ordered but installdirs is required by others.
This patch is the simplest one, another solution being to remove completely
installdirs prerequisite.

Spotted by Christoph Berg with plr build.
---
 src/makefiles/pgxs.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/makefiles/pgxs.mk b/src/makefiles/pgxs.mk
index 8618aa1..ac12f7d 100644
--- a/src/makefiles/pgxs.mk
+++ b/src/makefiles/pgxs.mk
@@ -124,7 +124,7 @@ all: all-lib
 endif # MODULE_big
 
 
-install: all installdirs installcontrol installdata installdatatsearch installdocs installscripts
+install: all installcontrol installdata installdatatsearch installdocs installscripts | installdirs
 ifdef MODULES
 	$(INSTALL_SHLIB) $(addsuffix $(DLSUFFIX), $(MODULES)) '$(DESTDIR)$(pkglibdir)/'
 endif # MODULES
-- 
1.8.4.rc3


--nextPart1504425.HPg8ZNtvSs--

--nextPart1693598.58uvEAtsm9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (GNU/Linux)

iQEcBAABAgAGBQJSJZf2AAoJENsgH0yzVBebUAMH/3nejDHeovvUOiyjoguCU4i1
8fj9kOwe/rxSyiqSCUrZcUyRdTNLIc6g52axR66O5yiSYo7P0uv1WQfTUo5Zk0yz
Rd1VSuAmGxiNdysSubdE+F+ccxBMOb3FnifcD6ubo/9+biFfsnwwVrIYCVUKhh/Q
5WUFqTOffWGg9t3iBAhs6EK8UUULQiYuppOrE6rEcwuL2NET4VKxrjcTcH0oBa1w
kMyGqZZbU3+oBNp3Yo5xaw3lmvrS/Kr4ivd4eb2TypBrMPzrbICxpay1z5gLIp0S
MbgBnPecuBckDpSj9At31RpIDHs20vJqfwA7OLFmmc3lLABaJxtj4/JXMQpHE6o=
=PCA5
-----END PGP SIGNATURE-----

--nextPart1693598.58uvEAtsm9--