From: Tom Lane <tgl@sss.pgh.pa.us>
To: Maksim Milyutin <milyutinma@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Hint to set owner for tablespace directory
In-reply-to: <2615ea98-6537-1fcf-667a-09022063336a@postgrespro.ru>
References: <5ca60e1a-26f9-89fd-e912-021dd2b8afe2@gmail.com>
 <1bc2bc14-e42a-8d9c-d47c-3afac05de347@2ndquadrant.com>
 <2615ea98-6537-1fcf-667a-09022063336a@postgrespro.ru>
Comments: In-reply-to Maksim Milyutin <milyutinma@gmail.com>
	message dated "Fri, 31 Aug 2018 15:37:06 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17439.1535723980.1@sss.pgh.pa.us>
Date: Fri, 31 Aug 2018 09:59:40 -0400
Message-ID: <17440.1535723980@sss.pgh.pa.us>
Precedence: bulk

Maksim Milyutin <milyutinma@gmail.com> writes:
> 30.08.2018 19:52, Peter Eisentraut wrote:
>> I think the hint is backwards.  When you don't have permission to chmod
>> the tablespace directory, you probably want to fix the permissions on
>> the tablespace directory or its parent.

> In this case I propose to:
> - replace my initial hint message to the guess what to do if errno == 
> EPERM, smth like "You might need to install the PostgreSQL system user 
> as the owner of this directory";
> - add another hint if errno == EACCES: "Fix permissions on the parent 
> directories".

I agree with what I think Peter is saying: the hint should just recommend
fixing permissions on the directory, for either errno code.  The more
detail you try to give, the more likely the hint will be wrong
... especially when you're dealing with errno codes that aren't all that
well standardized, as these aren't.

			regards, tom lane