Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: Fix RLS checks for UPDATE/DELETE FOR PORTION OF leftover rows
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <a1e965bc-01c0-47cd-8588-4cb3e60a1184@eisentraut.org>
Date: Mon, 20 Jul 2026 14:59:51 +0800
Cc: Paul A Jungwirth <pj@illuminatedcomputing.com>,
 Dean Rasheed <dean.a.rasheed@gmail.com>,
 Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <174C770E-07C8-4400-AC80-A46BFC2B68DD@gmail.com>
References: <6C34A987-AC50-4477-BD71-2D4AFEE1A589@gmail.com>
 <CAJTYsWWJeKKY=Db3R2yP7X8CeHoEu1tFcrRHKRgAf4Fv5-P11g@mail.gmail.com>
 <07EF5F4D-4AA3-4C21-8868-9ACC0D8B6655@gmail.com>
 <B4648790-5945-4C73-AF5A-8CE8A812527E@gmail.com>
 <CA+renyWnvqWPPdfvV1GmGr9wzG5S6c3Th=gpn2ShN0RLhR-Fsg@mail.gmail.com>
 <CA+renyWYcQ=Yc1zQJ2UzLDF2cdHBHto-dRHw9s9EAA111ApEqQ@mail.gmail.com>
 <20DF964A-C291-491A-9126-62753DCBD7CE@gmail.com>
 <CA+renyU=1A7+_zyPdaa6TersUDPrX13ufDW-qdi1wGt_zxXCfA@mail.gmail.com>
 <CAEZATCWEsMTVTA4mOPidvPE4wEv=oVzurR+vSAPmeT4RS7FqCg@mail.gmail.com>
 <CA+renyX5Mk7oq-S2eX1q7656ThtynmN5J9TWp2fSvWuMPivPjA@mail.gmail.com>
 <CAEZATCXW3O9_cniVFtw76zFO5p9D06P1bwMvG8RU4_YFkm0iwA@mail.gmail.com>
 <CA+renyWqKvB86R2FBAUh=AWoyt40qMf7yHWzoHaBr15kyy+Tjw@mail.gmail.com>
 <49247968-DB60-4FF3-892F-CF910E63ADBA@gmail.com>
 <CA+renyX3xny=og54iiOcVe0C0kLqEX+4cBg4cF-odE9eXN_8QA@mail.gmail.com>
 <a1e965bc-01c0-47cd-8588-4cb3e60a1184@eisentraut.org>
To: Peter Eisentraut <peter@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/174C770E-07C8-4400-AC80-A46BFC2B68DD%40gmail.com>
Precedence: bulk


> On Jul 20, 2026, at 14:53, Peter Eisentraut <peter@eisentraut.org> =
wrote:
>=20
> On 16.07.26 17:35, Paul A Jungwirth wrote:
>> On Wed, Jul 15, 2026 at 6:10=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>>=20
>>> Actually, when I received v4, I was also working on addressing =
Dean=E2=80=99s comments.
>>>=20
>>> I reviewed both v4 and v5, made some small adjustments, and here is =
v6:
>>>=20
>>> * For the create_policy doc change, I changed =E2=80=9Ccheck new =
row=E2=80=9D to =E2=80=9Ccheck leftover rows=E2=80=9D.
>>> * For the =E2=80=9CSELECT rights=E2=80=9D comment, I moved it into =
the block comment, because its position in v5 looked like a placeholder.
>>> * For the tests, v4 and v5 added the new cases in the MERGE section. =
I added the test in a more direct section.
>>> * For the tests, v4 and v5 granted INSERT privilege. V6 =
intentionally does not, because the test runs UPDATE/DELETE FOR PORTION =
OF, and INSERT privilege is not required for inserting leftover rows by =
design.
>> I took a look. These all seem like improvements to me.
>=20
> committed v6

Thanks for committing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/