Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j3oQe-00018M-Ce for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Feb 2020 21:59:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j3oQd-0008St-6O for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Feb 2020 21:59:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j3oQc-0008S7-LP for pgsql-hackers@lists.postgresql.org; Mon, 17 Feb 2020 21:59:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j3oQa-0001aZ-3I for pgsql-hackers@lists.postgresql.org; Mon, 17 Feb 2020 21:59:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 01HLxcmP017507; Mon, 17 Feb 2020 16:59:38 -0500 From: Tom Lane To: Alvaro Herrera cc: Pg Hackers , Amit Langote Subject: Re: pg_trigger.tgparentid In-reply-to: <20200217215641.GA29784@alvherre.pgsql> References: <20200217215641.GA29784@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Mon, 17 Feb 2020 18:56:41 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17505.1581976778.1@sss.pgh.pa.us> Date: Mon, 17 Feb 2020 16:59:38 -0500 Message-ID: <17506.1581976778@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > As mentioned in https://postgr.es/m/20191231194759.GA24692@alvherre.pgsql > I propose to add a new column to pg_trigger, which allows us to remove a > pg_depend scan when cloning triggers when adding/attaching partitions. > (It's not that I think the scan is a performance problem, but rather > than notionally we try not to depend on pg_depend contents for this kind > of semantic derivation.) It'd be nice if the term "parent trigger" were defined somewhere in this. Seems all right otherwise. regards, tom lane