Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vXSEV-00Agxx-2v
	for pgsql-hackers@arkaria.postgresql.org;
	Sun, 21 Dec 2025 22:49:00 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vXSEU-00CXpE-1V
	for pgsql-hackers@arkaria.postgresql.org;
	Sun, 21 Dec 2025 22:48:59 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vXSEU-00CXo4-0T
	for pgsql-hackers@lists.postgresql.org;
	Sun, 21 Dec 2025 22:48:58 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vXSET-001sF7-17
	for pgsql-hackers@postgresql.org;
	Sun, 21 Dec 2025 22:48:58 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 5BLMms7N175164;
	Sun, 21 Dec 2025 17:48:54 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Bryan Green <dbryan.green@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance
 chain
In-reply-to: 
 <CA+hUKG+FRtqt0ZZVxb4e4h1gRnpECvehGB5JHqK73q8LxhbbVQ@mail.gmail.com>
References: <e2b16375-7430-4053-bda3-5d2194ff1880@gmail.com>
 <CA+hUKGJS=xdaQ6iCTSgvBrf8Cm+a_ZMmDjZYhdQX_srHkhOuqA@mail.gmail.com>
 <7f6779d5-7a0e-44c5-a85f-b4ef265db766@gmail.com>
 <35f9236e-95d8-4f31-ac6b-ec54b7de4bac@gmail.com>
 <7412f694-7c57-41e5-ae37-71136070b0da@gmail.com>
 <CA+hUKGLX7t_PZjcUGm2-hL52RsKwof4F+-ENN5qc0AOBMPY1_g@mail.gmail.com>
 <ac7fe47b-0079-4711-9c58-73467b1d262a@gmail.com>
 <e3b982d0-c56e-441e-a5d5-61de571e313c@gmail.com>
 <CA+hUKGJh0a_6EP8NLh6jjQjzzg=Nm_h9HMC19-tBww7ZqQDWVg@mail.gmail.com>
 <CA+hUKGKbWCzBPYGKuoTG2_8uCvrKuoHkvpbjxLUYhPDiJHapNg@mail.gmail.com>
 <1086088.1765593851@sss.pgh.pa.us>
 <CA+hUKGJOVyea=EqZaMy9nt0Js10+E9y1FYL0=E_+UskZi-3wXQ@mail.gmail.com>
 <26678db0-519e-4c77-9b34-c5f94f97f6b9@gmail.com>
 <1115993.1765607595@sss.pgh.pa.us>
 <CA+hUKGJdL8sLW_xbgQ3sfBRXSTOPAsw3iFF8Cv8aTGG2kxvbLw@mail.gmail.com>
 <CA+hUKG+FRtqt0ZZVxb4e4h1gRnpECvehGB5JHqK73q8LxhbbVQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Sun, 21 Dec 2025 23:41:51 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <175162.1766357334.1@sss.pgh.pa.us>
Date: Sun, 21 Dec 2025 17:48:54 -0500
Message-ID: <175163.1766357334@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/175163.1766357334%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> I pushed the cleanup patch.

fairywren's still not happy, though only in the v16 branch:

Could not determine contrib module type for test_cloexec
 at build.pl line 54.

This evidently is because the old MSVC build system doesn't
recognize

PROGRAM += test_cloexec
OBJS += $(WIN32RES) test_cloexec.o

Is there a reason for using += not just = here?  We could certainly
modify Mkvcbuild.pm to parse this if we need to, but it looks more
like a gratuitous difference from everyplace else than a useful
behavior.

			regards, tom lane