Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vIq2M-00GMQc-2E for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Nov 2025 15:12:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vIq2K-006RMs-0Y for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Nov 2025 15:12:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vIq2J-006RMk-2K for pgsql-hackers@lists.postgresql.org; Tue, 11 Nov 2025 15:11:59 +0000 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vIq2G-007AtE-1f for pgsql-hackers@lists.postgresql.org; Tue, 11 Nov 2025 15:11:58 +0000 Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-4ed917b5b18so40692391cf.1 for ; Tue, 11 Nov 2025 07:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1762873914; x=1763478714; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=NIvVh6m10vja7nistbgCdg2iLAMn/KxFH8qkFwyW9IM=; b=yIR23D6eN4PR9aWtlPzwqdwKiHRdb84pcFtwNEIZis1mV53gYeyUqiyWV+n0ON7G1L 25wWNBmxR/AzNTyJu427cwadghYhV+dFzzmLoJZNyqZ5UQ07YVNzcnhzAChsk37ZbUGc PPEP1SDvi0Bv2+XwKjm/9/tFsHp7/kTf1hGAma7HNuSg+2pFu/UlBc7jHO25eDm9I57g cDSJemEsG7ZUXEhCIuLlhzRXE57ntFolFnDlxA7803gpVCxyWRQ8araSk+wnWmwTCzZ6 6ZSwH+WmPKSEZwqNlhBeDRP822ocI48pm2wUhPPOUg9EtFPWaqq2S5CaAjYUyf1Rth2c 6cxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762873914; x=1763478714; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NIvVh6m10vja7nistbgCdg2iLAMn/KxFH8qkFwyW9IM=; b=u7xm70q/QwoD2fmogYywhDX4hsZ5hLRxBJCNtwFliI06WqILpUb/k1ipTnodWfajYL Eo68KvXUzY/lODp7FQ++4h4Jnwdy2OxgWgJ7Wdy+KUBoTm/bsXk/L/odzQRcbzPX0ajd 9TzZHQ/7yZLQFvBx2XWUFGdtJP7nLBaOw20G/nbM6rgHdgJuwuRuVW3hZ1TXRmwGxWLi OoTL/rwN5/N7OFS2CCgGg/R+o9KtmaJo8mmAxgSednQoNHr6uf0vh0+vH/rYk69NFGpS gx6aH/8D3sMLryv3fAYHZbMhvQYVwelmXMjMyxLz06BjRAoxNpUFzJ4HnA4YO2+0J9Bl 5ejQ== X-Gm-Message-State: AOJu0YxcfSi48ghkrklgQ4B81cMnK/nJa+CP4621hZdnKYW2/9rL0cqO ihhfvMKy4YP13S7g9mIAHKfWRC0samtIclXpyNZ5kEcLnH50SJwj0OkXeSM1/YAoSvw= X-Gm-Gg: ASbGncuqRLYAjey60U7/G7ucOt0KkIUSTQaBU48q+g6HsNm4sNg/u7U1KnCTK1qWxKi 19jh9OIfuirzElJpn0H3lHURaiQbQS9d+CGb9mukaBDWZEcgv91qnUyKKCvQYQwVjqc9yHx5he9 VoRDdJujLymr7kxn8+6/2MASBpHeG1eXsDkqhHmcYTQ1iLKKPwDzUXAeCFNGRo5s48b8T7D69T8 OEZqVIkOFXG4jN+fqf+Rs07ddmlNsCNy0eGVu+0oghf7fTFifmOCjeYj6mxzxP+ReJHwkdNoaNj AEGrOPMHWIfHUEDAaPwaBeDkO9/unQdDQiaT54TSWUdiC5BSvSzmIoEXQtfmxhnYBkM8+bmO5cm yqWCmvYvXPmqsaPP0hc4t41NHgyI18qIBGCT5KCHHm0XqdoU/BhyGnduRrQaw3Sm71/X2JVxUoZ XWosNDnpQ= X-Google-Smtp-Source: AGHT+IHFD2TF+BPsyuiCxnXSTQhVaa6qJc9wHlx3FVLHKN8842+TwGzOHfjVKPIFBQ0G/JeHzFS3Hw== X-Received: by 2002:a05:622a:11c3:b0:4ed:142:ed5d with SMTP id d75a77b69052e-4eda4f90a86mr152877461cf.50.1762873914327; Tue, 11 Nov 2025 07:11:54 -0800 (PST) Received: from ?IPV6:2605:a601:a6b0:500::1cb? ([2605:a601:a6b0:500::1cb]) by smtp.googlemail.com with ESMTPSA id d75a77b69052e-4eda57ad8e6sm67741891cf.27.2025.11.11.07.11.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Nov 2025 07:11:53 -0800 (PST) Message-ID: <17555e46-4fb2-4265-90e0-95cb8ed584a6@dunslane.net> Date: Tue, 11 Nov 2025 10:11:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Non-text mode for pg_dumpall To: Mahendra Singh Thalor , Vaibhav Dalvi Cc: pgsql-hackers@lists.postgresql.org References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net> <2bed001a-462c-42da-9a6b-3c7884502932@dunslane.net> <20250824010811.4d.nmisch@google.com> <82eb35b8-7f07-493b-b689-0934919e1dc3@dunslane.net> From: Andrew Dunstan Content-Language: en-US Autocrypt: addr=andrew@dunslane.net; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/ qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm VRu7cmw= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-11-11 Tu 12:59 AM, Mahendra Singh Thalor wrote: > > Hi, > Here, I am attaching an updated patch for the review and testing. > > FIX: as suggested by Vaibhav, added error for --restrict-key option > with non-text format. > Regarding the name and format of the globals toc file, I'm inclined to think we should always use custom format, regardless of whether the individual databases will be in custom, tar or directory formats, and that it should be called something distinguishable, e.g. toc.glo. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com