public inbox for [email protected]
help / color / mirror / Atom feedFrom: Rohit Prasad <[email protected]>
To: [email protected]
Cc: Matheus Alcantara <[email protected]>
Subject: Re: Include extension path on pg_available_extensions
Date: Tue, 11 Nov 2025 02:06:14 +0000
Message-ID: <176282677490.2081919.14769189141245328542.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <[email protected];lightning.caipicrew.dd-dns.de>
References: <[email protected]>
<[email protected];lightning.caipicrew.dd-dns.de>
Hi Michael,
I am just getting started in the Postgres community (this is my first code review). So please excuse me if I have missed something (in terms of process etc).
I reviewed your proposed code changes in the attached patch file and they look good to me. I have some minor comments:
1. In src/test/modules/test_extensions/t/001_extension_control_path.pl, it would be nice if you could add a test that validates that the correct Extension location is displayed, if for example, the extension is being picked up from a customized location.
2. Nit-pick: In src/backend/commands/extension.c:get_available_versions_for_extension(), you could probably combine the following 2 lines into one to say "'comment' & 'location' stay the same.
/* comment stays the same */
/* location stays the same */
Hope this is helpful.
Thanks,
-Rohit
view thread (23+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Include extension path on pg_available_extensions
In-Reply-To: <176282677490.2081919.14769189141245328542.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox