From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Justin Pryzby <pryzby@telsasoft.com>,
        Dipesh Pandit <dipesh.pandit@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Jeevan Ladhe <jeevanladhe.os@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        "Shinoda,
    Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>,
        Abhijit Menon-Sen <ams@toroid.org>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>,
        Mark Dilger <mark.dilger@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c (zstd workers)
In-reply-to: 
 <CA+TgmobaAEenohgeAu=B7GDVbb2u0tfDmtf221m+9-8QWXAwGQ@mail.gmail.com>
References: <20220311010223.GI28503@telsasoft.com>
 <CA+Tgmob6Rnjz-Qv32h3yJn8nnUkLhrtQDAS4y5AtsgtorAFHRA@mail.gmail.com>
 <20220312015253.zokhkwdn5xbbd4vf@alap3.anarazel.de>
 <CA+TgmoZ10QPYaUxe8+RfJT5ptyDe-ML=oE_FyyFa+sNS2GBgZw@mail.gmail.com>
 <CAN1g5_F0KBgitEVLO8T0ynaBcQBfRMCjH9wKguDJZpX1hF3gFA@mail.gmail.com>
 <20220314163547.GT28503@telsasoft.com>
 <CA+TgmoaYrNxoGB8x_7Fk5uKXfbyMVAdSXTnfQN-1zu_3gB_v=Q@mail.gmail.com>
 <20220314171152.GU28503@telsasoft.com>
 <CA+TgmoYfV1ASq0QVR1QHaJnXfr+fPLoPByQL1SfWqjUuKtX_UA@mail.gmail.com>
 <CA+TgmoYvpetyRAbbg1M8b3-iHsaN4nsgmWPjOENu5-doHuJ7fA@mail.gmail.com>
 <20220317194130.GM28503@telsasoft.com>
 <CA+TgmoaaDXOT+vFDcPrnXjPTU7oFPY2_pkeQFTdSGJfrqO2LNQ@mail.gmail.com>
 <1565808.1647803514@sss.pgh.pa.us>
 <CA+TgmobaAEenohgeAu=B7GDVbb2u0tfDmtf221m+9-8QWXAwGQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Sun, 20 Mar 2022 21:24:17 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1765518.1647826365.1@sss.pgh.pa.us>
Date: Sun, 20 Mar 2022 21:32:45 -0400
Message-ID: <1765519.1647826365@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1765519.1647826365%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> I think I'm guilty of verbal inexactitude here but not bad coding.
> Checking for *endptr != '\0', as I did, is not sufficient to detect
> "whether an error occurred," as I alleged. But, in the part of my
> response you didn't quote, I believe I made it clear that I only need
> to detect garbage, not out-of-range values. And I think *endptr !=
> '\0' will do that.

Hmm ... do you consider an empty string to be valid input?

			regards, tom lane