Content-Type: multipart/mixed; boundary="------------Bx1AwiO64FLTL1plDjQO1lmJ"
Message-ID: <1765b44d-55e0-4ad2-a5f5-5492acf826b0@postgrespro.ru>
Date: Thu, 28 Nov 2024 22:08:51 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
From: Alena Rybakina <a.rybakina@postgrespro.ru>
To: Alexander Lakhin <exclusion@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 Andrei Lepikhov <lepihov@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Robert Haas
 <robertmhaas@gmail.com>, Nikolay Shaplov <dhyan@nataraj.su>,
 pgsql-hackers@lists.postgresql.org, pgsql-hackers@postgresql.org,
 Peter Geoghegan <pg@bowt.ie>, Marcos Pegoraro <marcos@f10.com.br>,
 teodor@sigaev.ru, Peter Eisentraut <peter@eisentraut.org>,
 Ranier Vilela <ranier.vf@gmail.com>
References: <567ED6CA.2040504@sigaev.ru>
 <CAPpHfds4wGdWQ2xx1OUKZC4ggqS6Q=cBSck9Re1ajY0ESkwcmw@mail.gmail.com>
 <CA+TgmoZ3tQ3Zwzo+9uXQL_tf0rDHQHKeZ4bGt1LDvL+_dqghUg@mail.gmail.com>
 <CAPpHfdt8kowRDUkmOnO7_WJJQ1uk+O379JiZCk_9_Pt5AQ4+0w@mail.gmail.com>
 <CAPpHfdu9QJ=Gbua3CUUH2KKG_8urakJTen4JD47PGh9wWP=QxQ@mail.gmail.com>
 <CAPpHfds3m=55cY1ea1TRzUAgD3pgwmvqm=exVMdOM4q+YT6kHg@mail.gmail.com>
 <45050ba9-3777-4cc1-89ad-a02deebe7729@gmail.com>
 <CAPpHfdvxF1OZUoJr2bg8cmAnty-KyRkswPa3hCPSmR5gSx7-Yg@mail.gmail.com>
 <CACJufxGS_MKqkfnw3BMhfi+=xuf2SAFvwf0Eq3e12XqAQaKdZg@mail.gmail.com>
 <0026f562-d403-4f97-b9dc-3fe3a279e8c9@postgrespro.ru>
 <CAPpHfduzBgV3AecMU0jFqOSjK9iP86HiHEzj2Hv6hLqWu7JJFQ@mail.gmail.com>
 <CAPpHfduqOuvh6i=jYDPWnAUg325hsOLUAW9r_awdirQRA7uzHA@mail.gmail.com>
 <37bf870a-22e0-4aba-b845-549482118f8d@gmail.com>
 <CAPpHfdtPkA3XGM+FOanXfFNm45YEMkuqpfL0ZSL7uOP1bHPPEg@mail.gmail.com>
 <8174de69-9e1a-0827-0e81-ef97f56a5939@gmail.com>
 <ed2b909c-35d4-4a39-ac38-8a15634a281b@postgrespro.ru>
Content-Language: en-US
In-Reply-To: <ed2b909c-35d4-4a39-ac38-8a15634a281b@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/1765b44d-55e0-4ad2-a5f5-5492acf826b0%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------Bx1AwiO64FLTL1plDjQO1lmJ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Sorry, I was in a hurry and forgot to add the test result. I updated the 
patch

On 28.11.2024 22:03, Alena Rybakina wrote:
> Hi! Thank you for the case.
>
> On 28.11.2024 21:00, Alexander Lakhin wrote:
>> Hello Alexander,
>>
>> 21.11.2024 09:34, Alexander Korotkov wrote:
>>> I'm going to push this if no objections.
>>
>> Please look at the following query, which triggers an error after 
>> ae4569161:
>> SET random_page_cost = 1;
>> CREATE TABLE tbl(u UUID);
>> CREATE INDEX idx ON tbl USING HASH (u);
>> SELECT COUNT(*) FROM tbl WHERE u = '00000000000000000000000000000000' OR
>>   u = '11111111111111111111111111111111';
>>
>> ERROR:  XX000: ScalarArrayOpExpr index qual found where not allowed
>> LOCATION:  ExecIndexBuildScanKeys, nodeIndexscan.c:1625
>>
>>
> I found out what the problem is index scan method was not generated. 
> We need to check this during OR clauses for SAOP transformation.
>
> There is a patch to fix this problem.
>
-- 
Regards,
Alena Rybakina
Postgres Professional

--------------Bx1AwiO64FLTL1plDjQO1lmJ
Content-Type: text/x-patch; charset=UTF-8; name="bugfix.diff"
Content-Disposition: attachment; filename="bugfix.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2luZHhwYXRoLmMgYi9z
cmMvYmFja2VuZC9vcHRpbWl6ZXIvcGF0aC9pbmR4cGF0aC5jCmluZGV4IGQ4MjdmYzlmNGQ5
Li42MTExMGRiNjVkZCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BhdGgv
aW5keHBhdGguYworKysgYi9zcmMvYmFja2VuZC9vcHRpbWl6ZXIvcGF0aC9pbmR4cGF0aC5j
CkBAIC0zMzAzLDYgKzMzMDMsMTAgQEAgbWF0Y2hfb3JjbGF1c2VfdG9faW5kZXhjb2woUGxh
bm5lckluZm8gKnJvb3QsCiAJCWlmIChnZXRfb3BfcmV0dHlwZShvcG5vKSAhPSBCT09MT0lE
KQogCQkJYnJlYWs7CiAKKwkJLyogSWdub3JlIGluZGV4IGlmIGl0IGRvZXNuJ3Qgc3VwcG9y
dCBpbmRleCBzY2FucyAqLworCQlpZighaW5kZXgtPmFtc2VhcmNoYXJyYXkpCisJCQlicmVh
azsKKwogCQkvKgogCQkgKiBDaGVjayBmb3IgY2xhdXNlcyBvZiB0aGUgZm9ybTogKGluZGV4
a2V5IG9wZXJhdG9yIGNvbnN0YW50KSBvcgogCQkgKiAoY29uc3RhbnQgb3BlcmF0b3IgaW5k
ZXhrZXkpLiAgRGV0ZXJtaW5lIGluZGV4a2V5IHNpZGUgZmlyc3QsIGNoZWNrCmRpZmYgLS1n
aXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2NyZWF0ZV9pbmRleC5vdXQgYi9zcmMv
dGVzdC9yZWdyZXNzL2V4cGVjdGVkL2NyZWF0ZV9pbmRleC5vdXQKaW5kZXggMWIwYTVmMGU5
ZTEuLmVmOGJiZjQ3NDhjIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVk
L2NyZWF0ZV9pbmRleC5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9jcmVh
dGVfaW5kZXgub3V0CkBAIC0xMjMzLDYgKzEyMzMsMjMgQEAgU0VMRUNUIGNvdW50KCopIEZS
T00gdGVuazEgV0hFUkUgc3RyaW5ndTEgPSAnVFZBQUFBJzsKICAgICAxNAogKDEgcm93KQog
CistLSBUcmFuc2Zvcm0gT1ItY2xhdXNlcyB0byBTQU9QJ3Mgc2hvdWxkbid0IGJlIGNob3Nl
bgorU0VUIHJhbmRvbV9wYWdlX2Nvc3QgPSAxOworRVhQTEFJTiAoQ09TVFMgT0ZGKQorU0VM
RUNUIENPVU5UKCopIEZST00gdGVuazEgV0hFUkUgc3RyaW5ndTEgPSAnVFZBQUFBJyBPUiAg
c3RyaW5ndTEgPSAnVFZBQUFCJzsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBRVUVSWSBQTEFOICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAor
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisgQWdncmVnYXRlCisgICAtPiAgQml0
bWFwIEhlYXAgU2NhbiBvbiB0ZW5rMQorICAgICAgICAgUmVjaGVjayBDb25kOiAoKHN0cmlu
Z3UxID0gJ1RWQUFBQSc6Om5hbWUpIE9SIChzdHJpbmd1MSA9ICdUVkFBQUInOjpuYW1lKSkK
KyAgICAgICAgIC0+ICBCaXRtYXBPcgorICAgICAgICAgICAgICAgLT4gIEJpdG1hcCBJbmRl
eCBTY2FuIG9uIGhhc2hfdHVwbGVzb3J0X2lkeAorICAgICAgICAgICAgICAgICAgICAgSW5k
ZXggQ29uZDogKHN0cmluZ3UxID0gJ1RWQUFBQSc6Om5hbWUpCisgICAgICAgICAgICAgICAt
PiAgQml0bWFwIEluZGV4IFNjYW4gb24gaGFzaF90dXBsZXNvcnRfaWR4CisgICAgICAgICAg
ICAgICAgICAgICBJbmRleCBDb25kOiAoc3RyaW5ndTEgPSAnVFZBQUFCJzo6bmFtZSkKKyg4
IHJvd3MpCisKK1JFU0VUIHJhbmRvbV9wYWdlX2Nvc3Q7CiBEUk9QIElOREVYIGhhc2hfdHVw
bGVzb3J0X2lkeDsKIFJFU0VUIG1haW50ZW5hbmNlX3dvcmtfbWVtOwogLS0KZGlmZiAtLWdp
dCBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2NyZWF0ZV9pbmRleC5zcWwgYi9zcmMvdGVzdC9y
ZWdyZXNzL3NxbC9jcmVhdGVfaW5kZXguc3FsCmluZGV4IGRkZDBkOWFkMzk2Li4wZTY1Mjlm
M2YzZCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvY3JlYXRlX2luZGV4LnNx
bAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9jcmVhdGVfaW5kZXguc3FsCkBAIC0zNzIs
NiArMzcyLDExIEBAIENSRUFURSBJTkRFWCBoYXNoX3R1cGxlc29ydF9pZHggT04gdGVuazEg
VVNJTkcgaGFzaCAoc3RyaW5ndTEgbmFtZV9vcHMpIFdJVEggKGZpCiBFWFBMQUlOIChDT1NU
UyBPRkYpCiBTRUxFQ1QgY291bnQoKikgRlJPTSB0ZW5rMSBXSEVSRSBzdHJpbmd1MSA9ICdU
VkFBQUEnOwogU0VMRUNUIGNvdW50KCopIEZST00gdGVuazEgV0hFUkUgc3RyaW5ndTEgPSAn
VFZBQUFBJzsKKy0tIFRyYW5zZm9ybSBPUi1jbGF1c2VzIHRvIFNBT1AncyBzaG91bGRuJ3Qg
YmUgY2hvc2VuCitTRVQgcmFuZG9tX3BhZ2VfY29zdCA9IDE7CitFWFBMQUlOIChDT1NUUyBP
RkYpCitTRUxFQ1QgQ09VTlQoKikgRlJPTSB0ZW5rMSBXSEVSRSBzdHJpbmd1MSA9ICdUVkFB
QUEnIE9SICBzdHJpbmd1MSA9ICdUVkFBQUInOworUkVTRVQgcmFuZG9tX3BhZ2VfY29zdDsK
IERST1AgSU5ERVggaGFzaF90dXBsZXNvcnRfaWR4OwogUkVTRVQgbWFpbnRlbmFuY2Vfd29y
a19tZW07CiAK

--------------Bx1AwiO64FLTL1plDjQO1lmJ--