From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Steele <david@pgmasters.net>
cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Stephen Frost <sfrost@snowman.net>
Subject: Re: C99 compliance for src/port/snprintf.c
In-reply-to: <6ae46827-45de-b3e7-4f19-01f9c48b28d4@pgmasters.net>
References: <17245.1534289329@sss.pgh.pa.us>
 <CA+TgmoaanyYh9KG49yWdhzU72Ngh7XG5Gs9rtceQfBg6WFaybA@mail.gmail.com>
 <9456.1534347706@sss.pgh.pa.us>
 <20180815155237.pz5fgfmdo4cgqjta@alap3.anarazel.de>
 <CA+TgmoYvHzFkwChsamwbBrLNJRcRq+fyTwveFaN_YOWUsRnfpw@mail.gmail.com>
 <11138.1534349838@sss.pgh.pa.us>
 <6ae46827-45de-b3e7-4f19-01f9c48b28d4@pgmasters.net>
Comments: In-reply-to David Steele <david@pgmasters.net>
	message dated "Wed, 15 Aug 2018 14:03:16 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17666.1534356548.1@sss.pgh.pa.us>
Date: Wed, 15 Aug 2018 14:09:08 -0400
Message-ID: <17667.1534356548@sss.pgh.pa.us>
Precedence: bulk

David Steele <david@pgmasters.net> writes:
> On 8/15/18 12:17 PM, Tom Lane wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> Personally, I'd prefer to
>>> continue avoiding // comments and intermingled declarations of
>>> variables and code on grounds of style and readability.

>> ... which I agree with.

> We already have -Wdeclaration-after-statement to prevent mixed
> declarations.  Not sure what to do about comments except manual enforcement.

pgindent will change // comments to /* style, so at least on the timescale
of a release cycle, we have enforcement for that.

			regards, tom lane