Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_568C6CEF-E18E-4156-B503-B58ED9AE023E";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: <D201EEF7-8681-458E-B287-7B8F058DC712@justatheory.com>
Date: Sat, 24 May 2025 17:46:49 -0400
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>,
 Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
Message-Id: <176C517D-2DEB-4CAB-9AE4-261079D313B9@justatheory.com>
References: 
 <CA+v5N40sJF39m0v7h=QN86zGp0CUf9F1WKasnZy9nNVj_VhCZQ@mail.gmail.com>
 <145894.1727298237@sss.pgh.pa.us>
 <CAPpHfdtGhn_5jfLoepOScyqT+FXYB9QtV-OEprychDcMJco7mw@mail.gmail.com>
 <CA+v5N42PVJH3HbwLE1yC75XR6E5zGnCCdtSUXfgFwtGyPP8XYg@mail.gmail.com>
 <CA+Tgmob03B6h1SMsi7vs9uOX+vrqg_tyhh--mKC3BaTJ08qKYA@mail.gmail.com>
 <7e9debe6-4e96-4b0d-a801-b531e962ef43@eisentraut.org>
 <01DC1C38-0692-461B-AA63-5394330356BE@gmail.com>
 <2568904.1748022721@sss.pgh.pa.us>
 <D57D3B5E-AF55-4F7F-9E55-FE06EE8ED811@justatheory.com>
 <40912112-7FFE-400F-A38F-368827C4BDF1@gmail.com>
 <D201EEF7-8681-458E-B287-7B8F058DC712@justatheory.com>
To: Florents Tselai <florents.tselai@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/176C517D-2DEB-4CAB-9AE4-261079D313B9%40justatheory.com>
Precedence: bulk


--Apple-Mail=_568C6CEF-E18E-4156-B503-B58ED9AE023E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On May 24, 2025, at 17:39, David E. Wheeler <david@justatheory.com> =
wrote:

> I=E2=80=99ve attached a new patch with docs.

Oh, and I forgot to mention, src/backend/utils/adt/jsonpath_scan.l looks =
like it has a ton of duplication in it. Shouldn=E2=80=99t it just add =
the new keywords, something like:

```
@@ -415,6 +415,11 @@ static const JsonPathKeyword keywords[] =3D {
    {4, false, WITH_P, "with"},
    {5, true, FALSE_P, "false"},
    {5, false, FLOOR_P, "floor"},
+   {5, false, STR_BTRIM_P, "btrim"},
+   {5, false, STR_LOWER_P, "lower"},
+   {5, false, STR_LTRIM_P, "ltrim"},
+   {5, false, STR_RTRIM_P, "rtrim"},
+   {5, false, STR_UPPER_P, "upper"},
    {6, false, BIGINT_P, "bigint"},
    {6, false, DOUBLE_P, "double"},
    {6, false, EXISTS_P, "exists"},
@@ -428,10 +433,13 @@ static const JsonPathKeyword keywords[] =3D {
    {7, false, INTEGER_P, "integer"},
    {7, false, TIME_TZ_P, "time_tz"},
    {7, false, UNKNOWN_P, "unknown"},
+   {7, false, STR_INITCAP_P, "initcap"},
+   {7, false, STR_REPLACEFUNC_P, "replace"},
    {8, false, DATETIME_P, "datetime"},
    {8, false, KEYVALUE_P, "keyvalue"},
    {9, false, TIMESTAMP_P, "timestamp"},
    {10, false, LIKE_REGEX_P, "like_regex"},
+   {10, false, STR_SPLIT_PART_P, "split_part"},
    {12, false, TIMESTAMP_TZ_P, "timestamp_tz"},
```

Best,

David


--Apple-Mail=_568C6CEF-E18E-4156-B503-B58ED9AE023E
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgyPkkACgkQkt9idPjI
gfEhrw/+NTPniU7h5ENAWDUnYZNMzWJ+iXmYeX7Ecv/B4D6NpUrJVtJWZ4ALjAhA
MuQInztvK2T995JgP4DnOBx+IgvHac3yjh2dzfMRaAQ6oH2qehTsSrGLdfgDovdu
jHXFJoIzQphKdbmcAm8ucmLzqFzPucO/soGR2Stm065jds3DWm6GFm/iQvgFhxiy
SkiKPQ70OUDCnNCTBArAjrCkWaYFSLIv2cMAXrCwofGJvZgW/3zjPLqwX6wuHrmB
8Nb2FS+ytLGl2UzURK5o/ZpVyvVEowTJsgkuXgjhPVhAJyNCxqZH4xOLvtqOws4e
UkYnR3zQcmvy0916zsGO+p4k/aPFPj+sx4+UtYZ6fd+UXqUMLlxvm9UtUOBtjhbk
YdMyFFmlFnfXcwFiPc/Nskw/3ULkWUHp42V24Ng62ZJBqhqtkImCg6PYUl0YwzV1
6qJtY0xCU+s/Iatj0hwMvsCTLgz+JV0sJknVtcXvA6y3CIPBwgaZxUgPyAieX0dC
70+jFg38XZAUWv9qgCi90VdjUrRp2MQ0AYF/KICpuywS2BEZJCtbfSJEwDbXZzYK
Cr6ToVok+T4EdYEYAdmjPA5KLnfd2QtfIiG+dlSPMPTDr5EsbnBLaGK4jGeuysmA
I6QjW+5jd+R19aoa9CPJPUyUJzDwvCaRJk9MIwCpYK6IjoG4XAM=
=pJsf
-----END PGP SIGNATURE-----

--Apple-Mail=_568C6CEF-E18E-4156-B503-B58ED9AE023E--