From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Pavan Deolasee <pavan.deolasee@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Failure in commit_ts tap tests
In-reply-to: <24cf2b76-9b9f-bba9-7e8b-89b9d0ba2471@2ndQuadrant.com>
References: 
 <CABOikdPhsHM+pX8skoEY1_T0OtKdO1udzUj4VCjU5VEt+bj4eA@mail.gmail.com>
 <19348.1484936537@sss.pgh.pa.us>
 <24cf2b76-9b9f-bba9-7e8b-89b9d0ba2471@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Mon, 23 Jan 2017 08:28:37 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17740.1485180194.1@sss.pgh.pa.us>
Date: Mon, 23 Jan 2017 09:03:14 -0500
Message-ID: <17741.1485180194@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 01/20/2017 01:22 PM, Tom Lane wrote:
>> It looks like at least part of the answer is that the buildfarm isn't
>> running this test.  AFAICS, it runs "make installcheck" not
>> "make check" in src/test/modules.  I don't know whether any of the
>> critters would have duplicated the failure, but they weren't trying.

> Is there a reason why these tests aren't run under installcheck? If
> there is a justification I can look at it, or we should decide on one
> canonical mode of running the tests and stick to that.

Well, for at least some of them, "make check" is necessary because they
need to change postmaster parameters or load special shared libraries.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers