From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Tomas Vondra <tomas.vondra@enterprisedb.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Yet another (minor) fix in BRIN
In-reply-to: <20201108015137.GA7294@alvherre.pgsql>
References: <20201108015137.GA7294@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Sat, 07 Nov 2020 22:51:37 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1776963.1604807126.1@sss.pgh.pa.us>
Date: Sat, 07 Nov 2020 22:45:26 -0500
Message-ID: <1776964.1604807126@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2020-Nov-08, Tomas Vondra wrote:
>> While rebasing some of the BRIN patches, I noticed some of the code in
>> brin_memtuple_initialize is duplicated. This happened in 8bf74967dab
>> which moved some of the code from brin_new_memtuple, not removing the
>> shared pieces. In practice this is benign, of course.
>> 
>> Barring objections I'll get the attached fix committed and backpatched.

> LGTM, thanks for noticing.

The weekend before stable-branch releases is probably not the best
time to be pushing "minor" fixes into those branches.  I got my
fingers burned today, and so did Peter.  Don't follow our example ;-)

			regards, tom lane