From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
cc: Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Splitting up guc.c
In-reply-to: <87v8psl5d8.fsf@wibble.ilmari.org>
References: <587607.1662836699@sss.pgh.pa.us> <Yx0vHEBXwcUggZYK@paquier.xyz>
 <666417.1662862120@sss.pgh.pa.us> <925946.1662918775@sss.pgh.pa.us>
 <1305798.1662935501@sss.pgh.pa.us>
 <20220912193928.wgrccx4b4k3solpu@awork3.anarazel.de>
 <1771845.1663011970@sss.pgh.pa.us> <87v8psl5d8.fsf@wibble.ilmari.org>
Comments: In-reply-to =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?=
 <ilmari@ilmari.org>
	message dated "Mon, 12 Sep 2022 21:12:03 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1778775.1663014026.1@sss.pgh.pa.us>
Date: Mon, 12 Sep 2022 16:20:26 -0400
Message-ID: <1778776.1663014026@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1778776.1663014026%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> Git can detect more complicated code movement (see the `--color-moved`
> option to `git diff`), but I'm not sure it's clever enough to realise
> that a change modifying a block of code that was moved in the meanwhile
> should be applied at the new destination.

Yeah, I suspect people will have to manually reapply any changes in
the GUC tables to guc_tables.c.  That'll be the same amount of work
for them whenever we commit this patch (unless theirs lands first,
in which case I have to deal with it).  The issue I think is
whether it's politer to make that happen during a CF or between
CFs.

			regards, tom lane