From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
cc: Corey Huinker <corey.huinker@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Michael Paquier <michael@paquier.xyz>,
        jian he <jian.universality@gmail.com>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Bruce Momjian <bruce@momjian.us>,
        Matthias van de Meent <boekewurm+postgres@gmail.com>,
        Magnus Hagander <magnus@hagander.net>,
        Stephen Frost <sfrost@snowman.net>,
        Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
        Peter Smith <smithpb2250@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        alvherre@alvh.no-ip.org
Subject: Re: Statistics Import and Export
In-reply-to: <a36e328ed4b8726eb43858c22be69aeb835173cd.camel@j-davis.com>
References: <sdno5atrplq5b67vcx7x6fkzevwkzojd23izbguy2yma424wmp@siwbi3ijxdxs> <x5yo5ly5u3dhzfaq3hrzeqhju3io5zmwk4yqrkge3ywcflffck@ghbbgsfv56yb> <3670503.1740173078@sss.pgh.pa.us> <blezfpeafycxlizyynwvwzh2vywmklhvfqudhicjrccu4raqpx@4ttfufowc2vo> <3728741.1740178078@sss.pgh.pa.us> <CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com> <97b451228227c555be1a4f79c4a62ddec9a74f06.camel@j-davis.com> <CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com> <b227c4fca29dfb893bb414ce6d84fc2377489ecc.camel@j-davis.com> <CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com> <y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw> <6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com> <CADkLM=cG8=gde_KjGiQC_wt0K3knJCy_mwvd-sW=f=3M2eSrEg@mail.gmail.com> <1698502.1740541206@sss.pgh.pa.us> <CADkLM=fZWAPyDxmHqxiJMUvrjbi2Fo1pHr+63_1d8yhStZ=sXQ@mail.gmail.com> <1704472.1740544569@sss.pgh.pa.us> <CADkLM=cCJFH7DE1W+nT4uAxgEL-gOBoKMQORJTnzmoX!
 ! TFw231w@mail.gmail.com> <1707557.1740546344@sss.pgh.pa.us> <CADkLM=crPjbcyvYEpKwd1hHkaSYgCtiYbN3+Zk3zoj4GrC-g3g@mail.gmail.com> <1778552.1740586434@sss.pgh.pa.us> <a36e328ed4b8726eb43858c22be69aeb835173cd.camel@j-davis.com>
Comments: In-reply-to Jeff Davis <pgsql@j-davis.com>
	message dated "Wed, 26 Feb 2025 08:16:31 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1779438.1740587015.1@sss.pgh.pa.us>
Date: Wed, 26 Feb 2025 11:23:35 -0500
Message-ID: <1779439.1740587015@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1779439.1740587015%40sss.pgh.pa.us>
Precedence: bulk

Jeff Davis <pgsql@j-davis.com> writes:
> I think you had mentioned upthread something about getting rid of the
> table-driven logic, which is fine with me. Did you mean for that to
> happen in this patch as well?

Per Corey's description of the patch (I didn't read it yet), some
of that already happened.  I want to get to buildfarm-green ASAP,
so I'm content to leave other cosmetic changes for later.

BTW, one cosmetic change that I'd like to see is that any tables that
don't go away get marked "const".  I tried to make that happen with
attribute_stats.c's tables in my WIP patch upthread, but found that
the need for const-ness would propagate to some utility functions and
such, so I put the idea on the back burner.

			regards, tom lane