public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ethan Mertz <[email protected]>
To: [email protected]
Cc: SATYANARAYANA NARLAPURAM <[email protected]>
Subject: Re: Skip prefetch for block references that follow a FPW or WILL_INIT of the same block
Date: Thu, 04 Jun 2026 20:07:00 +0000
Message-ID: <178060362097.594057.16093365170628444552.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CAHg+QDc761t7QpvyMU_ZaRyfnET_9xg0Vvt2kMbG7do6titTTg@mail.gmail.com>
References: <CAHg+QDf=eFFnOvmaPJQrXNiXaTOhhJhvO=DzmVUi=VGFRh5B0A@mail.gmail.com>
	<CAHg+QDc761t7QpvyMU_ZaRyfnET_9xg0Vvt2kMbG7do6titTTg@mail.gmail.com>

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi Satya,

I reviewed the v2 patch (0001-xlogprefetcher-record-FPW-WILL_INIT-...).

Applied cleanly to current HEAD, built with --enable-cassert and
--enable-debug, make check and make installcheck pass.

> Fixed this by making these blocks as recently seen in the FPW and WILL_INIT
> skip paths. The existing duplicate-check loop then naturally suppresses
> prefetch attempts for subsequent references to the same block, counting
> them under the skip_rep stat.

The approach integrates cleanly into the existing prefetch infrastructure
reusing the recently-seen window for deduplication rather than adding new
tracking state is a nice design choice.

I also agree with the choice to add this logic to init and fpw records but not the
filtered pages because these may still be beneficial to read later in the window.

I read through the code and it looks correct to me. One minor nit: there's
an extra blank line added just before lrq_complete_lsn that seems unrelated
to the change. Removing this would keep the diff focused.

I'm marking this Ready for Committer.

Best,
Ethan Mertz
SDE, Amazon Web Services

The new status of this patch is: Ready for Committer

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Skip prefetch for block references that follow a FPW or WILL_INIT of the same block
  In-Reply-To: <178060362097.594057.16093365170628444552.pgcf@coridan.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox