From: Antonin Houska <ah@cybertec.at>
To: Bruce Momjian <bruce@momjian.us>
cc: Stephen Frost <sfrost@snowman.net>, Sasasu <i@sasa.su>,
    Robert Haas <robertmhaas@gmail.com>,
    Andres Freund <andres@anarazel.de>,
    PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: XTS cipher mode for cluster file encryption
In-reply-to: <Ye8uzspNw7DzUMnD@momjian.us>
References: <20211013222648.GA373@momjian.us> <20211015192248.GP20998@tamriel.snowman.net> <20211015212109.ugwjuhe4lzymnorg@alap3.anarazel.de> <CA+TgmoaMHLXrxOj1HA+K=Z_qqgZUOpfdto8+QiVXsfP0ds+ojw@mail.gmail.com> <4b73c57e-0941-9e66-ea7e-087793c4c927@sasa.su> <20211019185456.GV20998@tamriel.snowman.net> <20211023160336.GB22621@momjian.us> <20211025155814.GD20998@tamriel.snowman.net> <18009.1638171451@antos> <Ye8uzspNw7DzUMnD@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
   message dated "Mon, 24 Jan 2022 17:57:18 -0500."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1780.1643697906.1@antos>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 01 Feb 2022 07:45:06 +0100
Message-ID: <1781.1643697906@antos>
Archived-At: <https://www.postgresql.org/message-id/1781.1643697906%40antos>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> wrote:

> On Mon, Nov 29, 2021 at 08:37:31AM +0100, Antonin Houska wrote:
> > The changes to buffile.c are not trivial, but we haven't really change=
d the
> > API, as long as you mean BufFileCreateTemp(), BufFileWrite(), BufFileR=
ead().
> > =

> > What our patch affects on the caller side is that BufFileOpenTransient=
(),
> > BufFileCloseTransient(), BufFileWriteTransient() and BufFileReadTransi=
ent()
> > replace OpenTransientFile(), CloseTransientFile(), write()/fwrite() an=
d
> > read()/fread() respectively in reorderbuffer.c and in pgstat.c. These =
changes
> > become a little bit less invasive in TDE 1.1 than they were in 1.0, se=
e [1],
> > see the diffs attached.
> =

> With pg_upgrade modified to preserve the relfilenode, tablespace oid, an=
d
> database oid, we are now closer to implementing cluster file encryption
> using XTS.  I think we have a few steps left:
> =

> 1.  modify temporary file I/O to use a more centralized API
> 2.  modify the existing cluster file encryption patch to use XTS with a
>     IV that uses more than the LSN
> 3.  add XTS regression test code like CTR
> 4.  create WAL encryption code using CTR
> =

> If we can do #1 in PG 15 I think I can have #2 ready for PG 16 in July.
> The feature wiki page is:
> =

> 	https://wiki.postgresql.org/wiki/Transparent_Data_Encryption
> =

> Do people want to advance this feature forward?

I confirm that we (Cybertec) do and that we're ready to spend more time on=
 the
community implementation.

-- =

Antonin Houska
Web: https://www.cybertec-postgresql.com