Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fgWLy-0001QY-6G
	for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Jul 2018 14:25:54 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fgWLw-0000Yv-OO
	for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Jul 2018 14:25:52 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fgWLw-0000Yo-He
	for pgsql-hackers@lists.postgresql.org; Fri, 20 Jul 2018 14:25:52 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fgWLt-0007Bo-Oq
	for pgsql-hackers@postgresql.org; Fri, 20 Jul 2018 14:25:51 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w6KEPlkD017834;
	Fri, 20 Jul 2018 10:25:47 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Victor Wagner <vitus@wagner.pp.ru>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Non-portable shell code in pg_upgrade tap tests
In-reply-to: <20180720153820.69e9ae6c@fafnir.local.vm>
References: <20180720153820.69e9ae6c@fafnir.local.vm>
Comments: In-reply-to Victor Wagner <vitus@wagner.pp.ru>
	message dated "Fri, 20 Jul 2018 15:38:20 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17832.1532096747.1@sss.pgh.pa.us>
Date: Fri, 20 Jul 2018 10:25:47 -0400
Message-ID: <17833.1532096747@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Victor Wagner <vitus@wagner.pp.ru> writes:
> I've discovered that in the branch REL_11_STABLE there is shell script
> src/bin/pg_upgrade/test.sh which doesn't work under Solaris 10.
> (it uses $(command) syntax with is not compatible with original
> Solaris /bin/sh)

OK ...

> It is quite easy to replace $() syntax with backticks. Backticks are
> not nestable and considered unsafe by modern shell scripting style
> guides, but they do work with older shells.

Please send a patch.  Most of us do not have access to old shells
we could test this on.  (The oldest machine I have, and it's old
enough to vote, does run that script ... I doubt very many other
developers have anything older.)

			regards, tom lane