From: Paul Kim <mok03127@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum
Date: Sun, 19 Jul 2026 23:27:54 +0900
Message-ID: <178447127453.110.12276981925360691905@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6537667262090389949=="
Archived-At: 
 <https://www.postgresql.org/message-id/178447127453.110.12276981925360691905%40mail.gmail.com>
Precedence: bulk

--===============6537667262090389949==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Hi,

ginVacuumPostingTreeLeaves() sweeps the leaf pages of a GIN posting tree
via their rightlinks, but that loop has no vacuum_delay_point() (and hence
no CHECK_FOR_INTERRUPTS()), unlike the sibling loops in ginbulkdelete() and
ginvacuumcleanup().

The call used to be there: it was dropped when fd83c83d094 rewrote this
cleanup from a recursive walk into the current iterative sweep, and never
re-added to the new loop.  That commit was only about fixing a deadlock, so
the removal looks inadvertent.

A posting tree holds all TIDs for a single key, so for a common key it can
span many leaf pages.  While one such tree is being vacuumed, the operation
now ignores vacuum_cost_delay and cannot be interrupted (query cancel,
statement_timeout, or autovacuum cancellation when another backend wants a
conflicting lock) until the whole sweep finishes; a corrupted rightlink
forming a cycle turns it into an uninterruptible hang.

The attached patch restores the call, placed where the buffer has already
been released so no content lock is held across the delay.  It is against
master; on branches before 18 vacuum_delay_point() takes no argument (the
is_analyze parameter was added by e5b0b0ce150), so the back-branch version
is just "vacuum_delay_point();".

I left the initial leftmost-descent loop in the same function as-is, since
it mirrors the entry-tree descent in ginbulkdelete(), which likewise has no
delay point.

Thanks,
Paul

--===============6537667262090389949==
Content-Type: text/x-patch
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="v1-0001-Restore-vacuum_delay_point-in-GIN-posting-tree-le.patch"
MIME-Version: 1.0

RnJvbSBkOWI1ZGRiM2NiMGNmYjU1ZDQxOGEwOWY1NzFhNzhlZTA2OWViM2UxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEtpbSA8bW9rMDMxMjdAZ21haWwuY29tPgpEYXRlOiBT
dW4sIDE5IEp1bCAyMDI2IDIzOjA4OjEyICswOTAwClN1YmplY3Q6IFtQQVRDSCB2MV0gUmVzdG9y
ZSB2YWN1dW1fZGVsYXlfcG9pbnQoKSBpbiBHSU4gcG9zdGluZy10cmVlIGxlYWYKIHZhY3V1bQoK
Q29tbWl0IGZkODNjODNkMDk0IHR1cm5lZCB0aGUgcmVjdXJzaXZlIHBvc3RpbmctdHJlZSBjbGVh
bnVwIGluCmdpblZhY3V1bVBvc3RpbmdUcmVlTGVhdmVzKCkgaW50byBhbiBpdGVyYXRpdmUgc3dl
ZXAgdGhhdCBmb2xsb3dzIHRoZQp0cmVlJ3MgbGVhZiBwYWdlcyB2aWEgdGhlaXIgcmlnaHRsaW5r
cy4gIFRoZSByZWN1cnNpdmUgdmVyc2lvbiBjYWxsZWQKdmFjdXVtX2RlbGF5X3BvaW50KCkgd2hp
bGUgcHJvY2Vzc2luZyB0aGUgdHJlZSwgYnV0IHRoYXQgY2FsbCB3YXMgcmVtb3ZlZAphbmQgbmV2
ZXIgcmUtYWRkZWQgdG8gdGhlIG5ldyBsb29wLiAgQXMgdGhhdCBjb21taXQgb25seSBzZXQgb3V0
IHRvIGZpeCBhCmRlYWRsb2NrLCB0aGUgcmVtb3ZhbCBhcHBlYXJzIHRvIGhhdmUgYmVlbiB1bmlu
dGVudGlvbmFsLgoKQ29uc2VxdWVudGx5IHRoZSBsZWFmLXBhZ2Ugc3dlZXAgb2YgYSBzaW5nbGUg
cG9zdGluZyB0cmVlIHJ1bnMgd2l0aCBubwp2YWN1dW1fZGVsYXlfcG9pbnQoKSwgYW5kIHRoZXJl
Zm9yZSBubyBDSEVDS19GT1JfSU5URVJSVVBUUygpLiAgQSBwb3N0aW5nCnRyZWUgc3RvcmVzIGFs
bCB0aGUgVElEcyBmb3Igb25lIGluZGV4ZWQga2V5LCBzbyBmb3IgYSBmcmVxdWVudGx5LW9jY3Vy
cmluZwprZXkgaXQgY2FuIHNwYW4gYSBsYXJnZSBudW1iZXIgb2YgbGVhZiBwYWdlcy4gIFdoaWxl
IHN1Y2ggYSB0cmVlIGlzIGJlaW5nCnZhY3V1bWVkIHRoZSBvcGVyYXRpb24gaWdub3JlcyB2YWN1
dW1fY29zdF9kZWxheSBhbmQgZG9lcyBub3QgcmVzcG9uZCB0bwpxdWVyeSBjYW5jZWxsYXRpb24g
b3Igc3RhdGVtZW50X3RpbWVvdXQ7IGFuIGF1dG92YWN1dW0gd29ya2VyIGxpa2V3aXNlCmNhbm5v
dCBiZSBpbnRlcnJ1cHRlZCBtaWQtc3dlZXAgd2hlbiBhbm90aGVyIGJhY2tlbmQgcmVxdWVzdHMg
YSBjb25mbGljdGluZwpsb2NrLiAgQSBjb3JydXB0ZWQgcmlnaHRsaW5rIHRoYXQgZm9ybXMgYSBj
eWNsZSBtYWtlcyB0aGUgbG9vcCBydW4KdW5pbnRlcnJ1cHRpYmx5IGZvcmV2ZXIuCgpSZXN0b3Jl
IHRoZSBjYWxsLCBwbGFjZWQgYWZ0ZXIgdGhlIGN1cnJlbnQgcGFnZSBoYXMgYmVlbiB1bmxvY2tl
ZCBhbmQKcmVsZWFzZWQgc28gdGhhdCBubyBidWZmZXIgY29udGVudCBsb2NrIGlzIGhlbGQgYWNy
b3NzIGEgcG90ZW50aWFsIGRlbGF5CihjZi4gMjFjMjdhZjY1ZmIpLiAgVGhlIHNpYmxpbmcgbG9v
cHMgaW4gZ2luYnVsa2RlbGV0ZSgpIGFuZApnaW52YWN1dW1jbGVhbnVwKCkgYWxyZWFkeSBjYWxs
IHZhY3V1bV9kZWxheV9wb2ludCgpIG9uY2UgcGVyIHBhZ2UuCgpCYWNrLXBhdGNoIHRvIGFsbCBz
dXBwb3J0ZWQgYnJhbmNoZXMsIHdoaWNoIGFsbCBjb250YWluIGZkODNjODNkMDk0LgotLS0KIHNy
Yy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2ludmFjdXVtLmMgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwg
MiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL2dpbi9naW52
YWN1dW0uYyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2ludmFjdXVtLmMKaW5kZXggODQwNTQz
ZWI2NjQuLmEwYjgxYTIxNWE5IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvZ2luL2dp
bnZhY3V1bS5jCisrKyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2ludmFjdXVtLmMKQEAgLTQy
OSw2ICs0MjksOCBAQCBnaW5WYWN1dW1Qb3N0aW5nVHJlZUxlYXZlcyhHaW5WYWN1dW1TdGF0ZSAq
Z3ZzLCBCbG9ja051bWJlciBibGtubykKIAkJaWYgKGJsa25vID09IEludmFsaWRCbG9ja051bWJl
cikKIAkJCWJyZWFrOwogCisJCXZhY3V1bV9kZWxheV9wb2ludChmYWxzZSk7CisKIAkJYnVmZmVy
ID0gUmVhZEJ1ZmZlckV4dGVuZGVkKGd2cy0+aW5kZXgsIE1BSU5fRk9SS05VTSwgYmxrbm8sCiAJ
CQkJCQkJCQlSQk1fTk9STUFMLCBndnMtPnN0cmF0ZWd5KTsKIAkJTG9ja0J1ZmZlcihidWZmZXIs
IEdJTl9FWENMVVNJVkUpOwotLSAKMi41MC4xIChBcHBsZSBHaXQtMTU1KQoK

--===============6537667262090389949==--