From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PG versus libxml2 2.12.x
In-reply-to: <a9e2f184-6267-4f74-9922-9211d78f6f9a@eisentraut.org>
References: <1389505.1706382262@sss.pgh.pa.us>
 <a9e2f184-6267-4f74-9922-9211d78f6f9a@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Mon, 29 Jan 2024 15:56:12 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1784722.1706541587.1@sss.pgh.pa.us>
Date: Mon, 29 Jan 2024 10:19:47 -0500
Message-ID: <1784723.1706541587@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1784723.1706541587%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> On 27.01.24 20:04, Tom Lane wrote:
>> I don't mind adopting the "const" --- it's a good idea in isolation.
>> The trouble is in fixing our code to work with both old and new
>> libxml2 versions.  We could thrash around with a configure test or
>> something, but I think the most expedient answer is just to insert
>> some explicit casts, as shown in the attached.  It's possible though
>> that some compilers will throw a cast-away-const warning.  I'm
>> not seeing any, but ...

> In PL/Tcl, we used to have these CONST84 and CONST86 things, for similar 
> reasons.  Maybe that would be another approach.

Yeah, if the simple cast approach turns out to create warnings,
we'll have to fall back on using actually different declarations.
I'm hoping to not have to go there.

			regards, tom lane