From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
cc: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
        Dilip Kumar <dilipbalaut@gmail.com>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Segfault on logical replication to partitioned table with foreign
 children
In-reply-to: <1361869.1667329814@sss.pgh.pa.us>
References: <6b93e3748ba43298694f376ca8797279d7945e29.camel@gmail.com>
 <CAFiTN-vvnrvHeUibhwhnJNgTyE70DcBTgXPws3iO7HVM9TWANg@mail.gmail.com>
 <188734.1667137161@sss.pgh.pa.us>
 <OSZPR01MB6310B855B1B90FEE433A98F4FD379@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <04b5212cd549ee3c8efc63f6a92d85d5463bfdf1.camel@gmail.com>
 <1361869.1667329814@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Tue, 01 Nov 2022 15:10:14 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1787917.1667407062.1@sss.pgh.pa.us>
Date: Wed, 02 Nov 2022 12:37:42 -0400
Message-ID: <1787918.1667407062@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1787918.1667407062%40sss.pgh.pa.us>
Precedence: bulk

Since we're getting pretty close to the next set of back-branch releases,
I went ahead and pushed a minimal fix along the lines suggested by Shi Yu.
(I realized that there's a second ExecFindPartition call in worker.c that
also needs a check.)  We still can at leisure think about refactoring
CheckSubscriptionRelkind to avoid unnecessary lookups.  I think that
is something we should do only in HEAD; it'll just be a marginal savings,
not worth the risks of API changes in stable branches.  The other loose
end is whether to worry about a regression test case.  I'm inclined not
to bother.  The only thing that isn't getting exercised is the actual
ereport, which probably isn't in great need of routine testing.

			regards, tom lane