From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: Amit Kapila <amit.kapila16@gmail.com>,
        tushar <tushar.ahuja@enterprisedb.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_resetwal is broken if run from v10 against older version of PG
 data directory
In-reply-to: 
 <CAB7nPqSfMCncBr4JdxKkgwqP5J--6czHMoeYzMAjTnCYqXoJog@mail.gmail.com>
References: <f4b8eb91-b934-8a0d-b3cc-68f06e2279d1@enterprisedb.com>
 <CAA4eK1JD_i5P3iRViF601FehMvkCrP=jmuYuV==OsrtFKhNa8A@mail.gmail.com>
 <cd63c926-7601-5b4d-788f-5295c5a9dcc8@enterprisedb.com>
 <CAA4eK1LPHkczLTTsN7rHpxMp0Fee9qyrgBXpRn_sNYVhRga-SQ@mail.gmail.com>
 <11442.1496073654@sss.pgh.pa.us>
 <CAB7nPqSfMCncBr4JdxKkgwqP5J--6czHMoeYzMAjTnCYqXoJog@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Mon, 29 May 2017 09:55:26 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1790.1496092371.1@sss.pgh.pa.us>
Date: Mon, 29 May 2017 17:12:51 -0400
Message-ID: <1791.1496092371@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> Agreed. Shouldn't this be back-patched? PG_CONTROL_VERSION has not
> been bumped between 9.4 and 9.5. Attached is a patch for HEAD.

Pushed with minor adjustments.  Notably, I didn't take your addition
of canonicalize_path() and referencing the file by absolute path.
That seems like an independent and rather debatable behavioral change.
All the other files that pg_resetwal touches are referenced with
relative paths; if we did want to change the reporting, shouldn't we
change it for all of them?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers