From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Michael Paquier <michael@paquier.xyz>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX INDEX results in a crash for an index of pg_class since
 9.6
In-reply-to: <20190502210253.lt4p46dvllxarajg@alap3.anarazel.de>
References: <27459.1556762513@sss.pgh.pa.us>
 <20190502021913.axyvyyyw5547swy5@alap3.anarazel.de>
 <25661.1556808540@sss.pgh.pa.us>
 <20190502153107.o5zadep4ehebzoqy@alap3.anarazel.de>
 <4870.1556811688@sss.pgh.pa.us>
 <20190502155612.ep5wqyninmkrz6uh@alap3.anarazel.de>
 <5531.1556812964@sss.pgh.pa.us> <2157.1556816395@sss.pgh.pa.us>
 <20190502172851.klckhiyukqd3bd2t@alap3.anarazel.de>
 <10650.1556830451@sss.pgh.pa.us>
 <20190502210253.lt4p46dvllxarajg@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 02 May 2019 14:02:53 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17926.1556839099.1@sss.pgh.pa.us>
Date: Thu, 02 May 2019 19:18:19 -0400
Message-ID: <17927.1556839099@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-02 16:54:11 -0400, Tom Lane wrote:
>> I just finished a successful run of the core regression tests with CCA.
>> Given the calendar, I think that's about as much CCA testing as I should
>> do personally.  I'll make a cleanup pass on this patch and try to get it
>> pushed within a few hours, if there are not objections.

> Sounds good to me.

Pushed --- hopefully, we have enough time before Sunday that we can get
reasonably complete buildfarm testing.

I did manually verify that all branches get through "reindex table
pg_class" and "reindex index pg_class_oid_index" under
CLOBBER_CACHE_ALWAYS, as well as a normal-mode check-world.  But CCA
world runs seem like a good idea.

As far as a permanent test scheme goes, I noticed while testing that
src/bin/scripts/t/090_reindexdb.pl and
src/bin/scripts/t/091_reindexdb_all.pl seem to be giving us a good
deal of coverage on this already, although of course they never caught the
problem with non-HOT updates, nor any of the deadlock issues.  Still,
it seems like maybe a core regression test that's been lobotomized enough
to be perfectly parallel-safe might not give us more coverage than can
be had there.

			regards, tom lane