From: Manu <manuelreyesbravo@gmail.com>
To: Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: Ajit Awekar <ajitpostgres@gmail.com>,
 Etsuro Fujita <etsuro.fujita@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, shihao zhong <zhong950419@gmail.com>,
 Nikita Malakhov <hukutoc@gmail.com>,
 Jehan-Guillaume de Rorthais <jgdr@dalibo.com>,
 pgsql-hackers@lists.postgresql.org, rhaas@postgresql.org
Subject: Re: [(known) BUG] DELETE/UPDATE more than one row in partitioned
 foreign table
Date: Wed, 28 Oct 2026 15:32:44 -0300
Message-ID: <179321236488.520440.320467809486544701@gmail.com>
In-Reply-To: 
 <CAKZiRmzpABcNuk+ZrhmV3=GtaA2S=C3=vKw_ggXCUwQUv8D4ag@mail.gmail.com>
References: 
 <CAKZiRmzpABcNuk+ZrhmV3=GtaA2S=C3=vKw_ggXCUwQUv8D4ag@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4290415659036867496=="
Archived-At: 
 <https://www.postgresql.org/message-id/179321236488.520440.320467809486544701%40gmail.com>
Precedence: bulk

--===============4290415659036867496==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Hi Jakub,

On Wed, Oct 28, 2026 at 10:12 AM Jakub Wartak
<jakub.wartak@enterprisedb.com> wrote:
>    postgres=# DELETE FROM fbig WHERE fbig.* IS NULL AND random() <= 1;
>    ERROR:  attribute 3 of type record has wrong type

Confirmed with V4 on master 126976a8ffc and fcfd2456078, and V3
already had it; master gives no error.  A DELETE whose local qual uses
the whole row fails the same way without random() and on a foreign
partition.  UPDATE works on a plain foreign table, but on a
foreign partition it fails with "record type has not been registered".

The ForeignScan's fdw_scan_tlist gets two whole-row entries, one typed
fbig and one RECORD: normalize_wholerow_vartype() retypes the qual's
Var (postgres_fdw.c:1515 with V4), so it no longer equal()s the one
from the reltarget and is appended (:1538).  setrefs.c matches on
varno/varattno only and takes the first, the fbig one.  The comment at
:1507 assumes core's RECORD Var is already there, which is true only
for UPDATE or with row DELETE triggers; with an AFTER DELETE row
trigger the RECORD entry comes first and the DELETE on the plain
foreign table works (on the partition it then fails like UPDATE).

Ajit, I'll set the entry to Ready for Committer once v5 covers this
and passes the eight cases plus the attached case_i_whole_row.sql.txt.

Regards,
Manu

--===============4290415659036867496==
Content-Type: text/plain
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="case_i_whole_row.sql.txt"
MIME-Version: 1.0

LS0gQ2FzZSBpOiB3aG9sZS1yb3cgcmVmZXJlbmNlIHRvIHRoZSBmb3JlaWduIHRhcmdldCBpbiBh
IG5vbi1wdXNoZWQKLS0gVVBEQVRFL0RFTEVURSAoSmFrdWIgV2FydGFrLCAyMDI2LTEwLTI4KS4g
IHJhbmRvbSgpIDw9IDEga2VlcHMgdGhlCi0tIFdIRVJFIGNsYXVzZSBsb2NhbCwgc28gdGhlIHNj
YW4gbXVzdCByZXR1cm4gdGhlIHdob2xlIHJvdy4KLS0gTmVlZHMgcG9zdGdyZXNfZmR3IGFuZCBh
IHNlcnZlciAibG9vcGJhY2siIHBvaW50aW5nIGF0IHRoaXMgZGF0YWJhc2UsCi0tIHNldCB1cCBh
cyBpbiBjb250cmliL3Bvc3RncmVzX2Zkdy9zcWwvcG9zdGdyZXNfZmR3LnNxbC4KQ1JFQVRFIFRB
QkxFIGJpZyAoaWQgaW50IHByaW1hcnkga2V5LCBhIGludCwgYiB0ZXh0KTsKSU5TRVJUIElOVE8g
YmlnIFNFTEVDVCBzLCBzLCAneCd8fHMgRlJPTSBnZW5lcmF0ZV9zZXJpZXMoMSwxMCkgczsKQU5B
TFlaRSBiaWc7CkNSRUFURSBGT1JFSUdOIFRBQkxFIGZiaWcgKGlkIGludCwgYSBpbnQsIGIgdGV4
dCkKICAgU0VSVkVSIGxvb3BiYWNrIE9QVElPTlMgKHRhYmxlX25hbWUgJ2JpZycpOwoKLS0gaTE6
IEpha3ViJ3Mgc3RhdGVtZW50CkVYUExBSU4gKFZFUkJPU0UsIENPU1RTIE9GRikKREVMRVRFIEZS
T00gZmJpZyBXSEVSRSBmYmlnLiogSVMgTlVMTCBBTkQgcmFuZG9tKCkgPD0gMTsKREVMRVRFIEZS
T00gZmJpZyBXSEVSRSBmYmlnLiogSVMgTlVMTCBBTkQgcmFuZG9tKCkgPD0gMTsKLS0gaTI6IHNh
bWUgd2l0aCBST1coLi4uKSBpbnN0ZWFkIG9mIGZiaWcuKgpERUxFVEUgRlJPTSBmYmlnIFdIRVJF
IFJPVyhpZCwgYSwgYikgSVMgTlVMTCBBTkQgcmFuZG9tKCkgPD0gMTsKLS0gaTM6IFVQREFURQpF
WFBMQUlOIChWRVJCT1NFLCBDT1NUUyBPRkYpClVQREFURSBmYmlnIFNFVCBhID0gLWEgV0hFUkUg
ZmJpZy4qIElTIE5VTEwgQU5EIHJhbmRvbSgpIDw9IDE7ClVQREFURSBmYmlnIFNFVCBhID0gLWEg
V0hFUkUgZmJpZy4qIElTIE5VTEwgQU5EIHJhbmRvbSgpIDw9IDE7Ci0tIGk0OiByb3dzIHRoYXQg
ZG8gbWF0Y2g6IG9uZSByb3cgbXVzdCBjaGFuZ2UsIG5vIG90aGVyCi0tIChyZWFkIHRocm91Z2gg
dGhlIEZEVzogdGhlIGxvb3BiYWNrJ3MgcmVtb3RlIHRyYW5zYWN0aW9uIGlzIG5vdAotLSB2aXNp
YmxlIHRvIGEgbG9jYWwgU0VMRUNUIG9uIGJpZyB1bnRpbCBjb21taXQpCkJFR0lOOwpERUxFVEUg
RlJPTSBmYmlnIFdIRVJFIGZiaWcuKiBJUyBOT1QgTlVMTCBBTkQgaWQgPSAyIEFORCByYW5kb20o
KSA8PSAxOwpTRUxFQ1QgKiBGUk9NIGZiaWcgV0hFUkUgaWQgPD0gMyBPUkRFUiBCWSBpZDsKUk9M
TEJBQ0s7CkJFR0lOOwpVUERBVEUgZmJpZyBTRVQgYSA9IC1hIFdIRVJFIGZiaWcgSVMgTk9UIE5V
TEwgQU5EIGlkID0gMyBBTkQgcmFuZG9tKCkgPD0gMTsKU0VMRUNUICogRlJPTSBmYmlnIFdIRVJF
IGlkIDw9IDMgT1JERVIgQlkgaWQ7ClJPTExCQUNLOwotLSBpNTogd2hvbGUgcm93IG9ubHkgaW4g
UkVUVVJOSU5HCkJFR0lOOwpVUERBVEUgZmJpZyBTRVQgYSA9IC1hIFdIRVJFIGlkID0gNCBBTkQg
cmFuZG9tKCkgPD0gMSBSRVRVUk5JTkcgZmJpZzsKREVMRVRFIEZST00gZmJpZyBXSEVSRSBpZCA9
IDUgQU5EIHJhbmRvbSgpIDw9IDEgUkVUVVJOSU5HIGZiaWc7ClJPTExCQUNLOwotLSBpNjogbm8g
cmFuZG9tKCk6IHdob2xlIHJvdyBpbiBXSEVSRQpFWFBMQUlOIChWRVJCT1NFLCBDT1NUUyBPRkYp
CkRFTEVURSBGUk9NIGZiaWcgV0hFUkUgZmJpZy4qIElTIE5VTEw7CkRFTEVURSBGUk9NIGZiaWcg
V0hFUkUgZmJpZy4qIElTIE5VTEw7CgotLSBpNzogZm9yZWlnbiB0YWJsZSBhcyBhIHBhcnRpdGlv
bgpDUkVBVEUgVEFCTEUgcjEgKGlkIGludCBwcmltYXJ5IGtleSwgYSBpbnQsIGIgdGV4dCk7CkNS
RUFURSBUQUJMRSByMiAoaWQgaW50IHByaW1hcnkga2V5LCBhIGludCwgYiB0ZXh0KTsKSU5TRVJU
IElOVE8gcjEgU0VMRUNUIHMsIHMsICd4J3x8cyBGUk9NIGdlbmVyYXRlX3NlcmllcygxLDUpIHM7
CklOU0VSVCBJTlRPIHIyIFNFTEVDVCBzLCBzLCAneCd8fHMgRlJPTSBnZW5lcmF0ZV9zZXJpZXMo
NiwxMCkgczsKQ1JFQVRFIFRBQkxFIHB0IChpZCBpbnQsIGEgaW50LCBiIHRleHQpIFBBUlRJVElP
TiBCWSBSQU5HRSAoaWQpOwpDUkVBVEUgRk9SRUlHTiBUQUJMRSBwdDEgUEFSVElUSU9OIE9GIHB0
IEZPUiBWQUxVRVMgRlJPTSAoMSkgVE8gKDYpCiAgIFNFUlZFUiBsb29wYmFjayBPUFRJT05TICh0
YWJsZV9uYW1lICdyMScpOwpDUkVBVEUgRk9SRUlHTiBUQUJMRSBwdDIgUEFSVElUSU9OIE9GIHB0
IEZPUiBWQUxVRVMgRlJPTSAoNikgVE8gKDExKQogICBTRVJWRVIgbG9vcGJhY2sgT1BUSU9OUyAo
dGFibGVfbmFtZSAncjInKTsKQU5BTFlaRSBwdDsKRVhQTEFJTiAoVkVSQk9TRSwgQ09TVFMgT0ZG
KQpERUxFVEUgRlJPTSBwdCBXSEVSRSBwdC4qIElTIE5VTEwgQU5EIHJhbmRvbSgpIDw9IDE7CkRF
TEVURSBGUk9NIHB0IFdIRVJFIHB0LiogSVMgTlVMTCBBTkQgcmFuZG9tKCkgPD0gMTsKRVhQTEFJ
TiAoVkVSQk9TRSwgQ09TVFMgT0ZGKQpVUERBVEUgcHQgU0VUIGEgPSAtYSBXSEVSRSBwdC4qIElT
IE5VTEwgQU5EIHJhbmRvbSgpIDw9IDE7ClVQREFURSBwdCBTRVQgYSA9IC1hIFdIRVJFIHB0Liog
SVMgTlVMTCBBTkQgcmFuZG9tKCkgPD0gMTsKQkVHSU47CkRFTEVURSBGUk9NIHB0IFdIRVJFIHB0
IElTIE5PVCBOVUxMIEFORCBpZCBJTiAoMiwgNykgQU5EIHJhbmRvbSgpIDw9IDE7ClNFTEVDVCAq
IEZST00gcHQgV0hFUkUgaWQgSU4gKDIsIDMsIDcsIDgpIE9SREVSIEJZIGlkOwpST0xMQkFDSzsK
QkVHSU47ClVQREFURSBwdCBTRVQgYSA9IC1hIFdIRVJFIHB0IElTIE5PVCBOVUxMIEFORCBpZCBJ
TiAoMywgOCkKICAgQU5EIHJhbmRvbSgpIDw9IDEgUkVUVVJOSU5HIHB0OwpTRUxFQ1QgKiBGUk9N
IHB0IFdIRVJFIGlkIElOICgyLCAzLCA3LCA4KSBPUkRFUiBCWSBpZDsKUk9MTEJBQ0s7CgotLSBp
ODogc2FtZSBERUxFVEVzIG9uY2UgYSByb3cgREVMRVRFIHRyaWdnZXIgZXhpc3RzLCB3aGljaCBt
YWtlcyBjb3JlCi0tIGFkZCBpdHMgb3duIFJFQ09SRCB3aG9sZS1yb3cgaWRlbnRpdHkgY29sdW1u
IChhcyBpdCBhbHdheXMgZG9lcyBmb3IKLS0gVVBEQVRFKQpDUkVBVEUgRlVOQ1RJT04gdHJpZ19u
b29wKCkgUkVUVVJOUyB0cmlnZ2VyIExBTkdVQUdFIHBscGdzcWwKICAgQVMgJCQgQkVHSU4gUkVU
VVJOIE9MRDsgRU5EICQkOwpDUkVBVEUgVFJJR0dFUiBmYmlnX2RlbCBBRlRFUiBERUxFVEUgT04g
ZmJpZwogICBGT1IgRUFDSCBST1cgRVhFQ1VURSBGVU5DVElPTiB0cmlnX25vb3AoKTsKQ1JFQVRF
IFRSSUdHRVIgcHQxX2RlbCBBRlRFUiBERUxFVEUgT04gcHQxCiAgIEZPUiBFQUNIIFJPVyBFWEVD
VVRFIEZVTkNUSU9OIHRyaWdfbm9vcCgpOwpDUkVBVEUgVFJJR0dFUiBwdDJfZGVsIEFGVEVSIERF
TEVURSBPTiBwdDIKICAgRk9SIEVBQ0ggUk9XIEVYRUNVVEUgRlVOQ1RJT04gdHJpZ19ub29wKCk7
CkJFR0lOOwpERUxFVEUgRlJPTSBmYmlnIFdIRVJFIGZiaWcuKiBJUyBOVUxMIEFORCByYW5kb20o
KSA8PSAxOwpERUxFVEUgRlJPTSBmYmlnIFdIRVJFIGZiaWcuKiBJUyBOT1QgTlVMTCBBTkQgaWQg
PSAyIEFORCByYW5kb20oKSA8PSAxOwpTRUxFQ1QgKiBGUk9NIGZiaWcgV0hFUkUgaWQgPD0gMyBP
UkRFUiBCWSBpZDsKUk9MTEJBQ0s7CkRFTEVURSBGUk9NIHB0IFdIRVJFIHB0LiogSVMgTlVMTCBB
TkQgcmFuZG9tKCkgPD0gMTsK

--===============4290415659036867496==--