Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xR0MG-00000000aUe-28sr for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Nov 2026 04:54:52 +0000 Received: from localhost ([127.0.0.1]:38818 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xR0MD-00000008ZYI-3OJJ for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Nov 2026 04:54:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:43368) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xR0MD-00000008ZY9-28vD for pgsql-hackers@lists.postgresql.org; Wed, 11 Nov 2026 04:54:49 +0000 Received: from mail-dy1-x1334.google.com ([2607:f8b0:4864:20::1334]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xR0MB-00000000OtU-2me7 for pgsql-hackers@lists.postgresql.org; Wed, 11 Nov 2026 04:54:49 +0000 Received: by mail-dy1-x1334.google.com with SMTP id 5a478bee46e88-36e895f329cso8166eec.3 for ; Tue, 10 Nov 2026 20:54:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794372886; x=1794977686; darn=lists.postgresql.org; h=content-type:mime-version:references:in-reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=udV3dDFUxMqwt1p6Jdnzb+L5T9tE4t+D1h6szKUoRYw=; b=T0ZCVT6RFPlfNHoixsd+mAEHeTQJEyRdIDOA0ba9F4efmYA4T0CMpv3394dtcc4Zo0 oUqZ0BwoBv+UOcbdgS6gGSEa+ytK6Af/xnqJG7R0jWfWQBHmKNifMo8752yqOVDXXVnh ZU3T3KEVCYJQJQhKMtSbSohksgOKPK5Ki+N8liOHs9E5a6nx3eEdr12b4RXzAFPK6SYC wYWEkEJlbIaxzxoOHh+o6wZ4Ga6ORjhunOrhQTzq8QHhjlSJWMlkktjTzEM3LuqUh/KN pkP5vvqSCpAXIUSyIBBolF2V1C9ebmNTB0423eXzLvxs05sSn5b+mD8vZQMEO0G1BxzB 2uYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794372886; x=1794977686; h=content-type:mime-version:references:in-reply-to:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=udV3dDFUxMqwt1p6Jdnzb+L5T9tE4t+D1h6szKUoRYw=; b=K57VEvuhiOIrS1SD/kFX7sskmiemgUJPP47J+itS/BmUfDvXFcV3Anjg0f7vF0p0dB Zr9RX2yxl010n5H0rEIpsSJiOkOk+U38SXIXYs7Qg6Djyi8rHgZ1slkpLrAAVUDVn/t5 pQCJtT27fJggHlEDPaulGj9yiiC6Q1wKLDNsgHZOxAuaaiPrnb6vYI6bPc01x0PcnHYS D97GBRA5bxl61Q7FXbzbhvm1GZmq42f1fbjd1opodIW1s7RBIzWJZCMciSn2eKWL9Aqb UBpTomZuZyJLzdiGvd5nKUplTTH0qnB3rkNvXgaMHheAkNz9nAyx1w7L4Ig9c1FBGOhS RagQ== X-Forwarded-Encrypted: i=1; AL+hErFbEeE3brhAxdrBDx6E6QF/ffVCrJ4TkWAPbqOugOtJY11kHVXx859WlM8VX4ew62fWA68uM80JB39Vg9tA@lists.postgresql.org X-Gm-Message-State: APuU4Z+iYAoT3wwv4+q5BKqZ9XvgN+IJ+dtkLxM+kVIIpkkuRs8j1qwt c27UbBGt7qrAoZbcVAWYPi0hipwfMJ49XozPGCdHluLxgN1Osxwvak5y X-Gm-Gg: AYBFou0g2/lokk/TefOumX2gnfwm2WjF5IdYVQVJQO/HAhxpcuvOxrAYj77zVdVhBlK AaGk7iHjnREqMOEQ7M95X1Ib/BVZX/zTkonAaFhu4RpYxzI2YPl0MDxfikunJKqLsv56ohR6qgr iLDGdMiYkGz+tqOcSKYFxoY/ohF7jK8UpD8I7s4FQHH2DkBJ85lW3ncO2pfHcWlZvFrS8H5lFgo xjBu8CY3C+VRDDcyxhjiDlAL3iDI8wvSP7PRtORaneo2uC4u8HPLsMcTmB6iOy+KspHvb9kAo5p FT7NYVWoCdQ23qnojzfWh+kWdMBKuQE8hIhVU51NbZIE86HHC9zAVNXtd9N5xAQTgWqbom9Nhat oHZVrwwBBVvxgIRzAS8UffNw33rjejg/J+WCQ5miQPb6B4q/F0RGHVvfmU+6aQw8oDTgxOcasKe n1Zb+8XlqZzJoosUY5wWdDYRNsUHVtVx23YY8heL3gGTL7LnBsuzaMo4Lh59hfq3RFYhkxvjd9/ 6dSbDcEWzc8cH213G6v5cm1/GnTjG1Em48acUAx20F1mHXhKX6cWCmccOhCCUALGu3IggKw4vjM FsQTnQi3pGdvcGEwjzQeqQMr+8avUAu1YyBHSwWpG4Xm96+TmZ5EAl2x7zWME89RZpjcQNvw1qL o9n/+pKJgDL+DfHfrED6pt5SpxeANP6QIK5pt/Eam/crIguuz3zy+T2I= X-Received: by 2002:a05:7300:e9d9:10b0:36a:143d:98db with SMTP id 5a478bee46e88-376854ba2demr3216191eec.1.1794372885235; Tue, 10 Nov 2026 20:54:45 -0800 (PST) Received: from 192.168.1.109 ([190.12.171.125]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3766146551asm4046194eec.1.2026.11.10.20.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 20:54:44 -0800 (PST) From: Manu To: Antonin Houska Cc: shihao zhong , pgsql-hackers@lists.postgresql.org Subject: Re: REPACK enhancements Date: Wed, 11 Nov 2026 01:54:29 -0300 Message-ID: <179437286912.972010.7397230238948706686@gmail.com> In-Reply-To: <88740.1794308080@chrudos> References: <88740.1794308080@chrudos> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6610718779935447398==" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --===============6610718779935447398== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hi Antonin, On Tue, Nov 10, 2026 at 11:54 AM Antonin Houska wrote: > For now I commented the assertion out and added a comment on possible > solutions. Leaving it out looks safe to me, and the check can stay. Every other caller passes GetCurrentTransactionId(), and in all the runs I made (UPDATE, DELETE, savepoints, TOAST, row lockers, 150 replayed calls) the replay reached the function with xmax still zero: the copy clears it and only REPACK writes to the new heap. So the attached assertion keeps the old check and states what REPACK relies on; it passes Shihao's spec and the existing REPACK tests. With assertions off, a REPEATABLE READ snapshot taken while REPACK waited for the lock saw the same rows as an untouched copy of the table in every one of those runs. A correction: in September I blamed the transient heap's XID, but that run had failed before the final lock. Shihao has it right. Regards, Manu --===============6610718779935447398== Content-Type: text/plain Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="nocfbot-xmax-invalid-assert.diff.txt" MIME-Version: 1.0 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy9oZWFwL2hlYXBhbS5jIGIvc3JjL2JhY2tl bmQvYWNjZXNzL2hlYXAvaGVhcGFtLmMKaW5kZXggMTliZTFhMzk5NWIuLjkwODZiNzliYzBjIDEw MDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvaGVhcC9oZWFwYW0uYworKysgYi9zcmMvYmFj a2VuZC9hY2Nlc3MvaGVhcC9oZWFwYW0uYwpAQCAtNTU3OCwxMiArNTU3OCwxNCBAQCBjb21wdXRl X25ld194bWF4X2luZm9tYXNrKFRyYW5zYWN0aW9uSWQgeG1heCwgdWludDE2IG9sZF9pbmZvbWFz aywKIAkJCQluZXdfaW5mb21hc2syOwogCiAJLyoKLQkgKiBUT0RPIE1vdmUgdGhpcyBzdGF0ZW1l bnQgdG8gY2FsbGVycz8gUkVQQUNLIChDT05DVVJSRU5UTFkpIHVzZXMKLQkgKiBhZGRfdG9feG1h eCBkaWZmZXJlbnQgZnJvbSB0aGUgY3VycmVudCB0cmFuc2FjdGlvbiB3aGVuIHJlcGxheWluZyBk YXRhCi0JICogY2hhbmdlcy4gQWx0ZXJuYXRpdmVseSwgd2UgY2FuIGFkZCBhIGJvb2xlYW4gYXJn dW1lbnQgdG8gdGhlIGZ1bmN0aW9uCi0JICogaW5kaWNhdGluZyB0aGUgc3BlY2lhbCBjYXNlLCBi dXQgdGhhdCBkb2VzIG5vdCBsb29rIG5pY2UuCi0JICovCi0JLy9Bc3NlcnQoVHJhbnNhY3Rpb25J ZElzQ3VycmVudFRyYW5zYWN0aW9uSWQoYWRkX3RvX3htYXgpKTsKKwkgKiBSRVBBQ0sgKENPTkNV UlJFTlRMWSkgcmVwbGF5cyBkYXRhIGNoYW5nZXMgd2l0aCB0aGUgWElEIG9mIHRoZQorCSAqIHRy YW5zYWN0aW9uIHRoYXQgbWFkZSB0aGVtIChUQUJMRV9SRVVTRV9YSUQpLCBzbyBhZGRfdG9feG1h eCBuZWVkIG5vdAorCSAqIGJlIG91cnMuICBJdCBvbmx5IHJlcGxheXMgdGhlbSBvbiB0dXBsZXMg b2YgdGhlIG5ldyBoZWFwIHRoYXQgbm9ib2R5CisJICogZWxzZSBjYW4gbG9jayBvciBtb2RpZnkg YW5kIHdob3NlIHhtYXggaXQgaGFzIG5vdCBzZXQsIHNvIHhtYXggaXMKKwkgKiBzdGlsbCBpbnZh bGlkIGhlcmUgYW5kIG91ciBvd24gdHJhbnNhY3Rpb24gZG9lcyBub3QgbWF0dGVyIGJlbG93Lgor CSAqLworCUFzc2VydChUcmFuc2FjdGlvbklkSXNDdXJyZW50VHJhbnNhY3Rpb25JZChhZGRfdG9f eG1heCkgfHwKKwkJICAgIVRyYW5zYWN0aW9uSWRJc1ZhbGlkKHhtYXgpKTsKIAogbDU6CiAJbmV3 X2luZm9tYXNrID0gMDsK --===============6610718779935447398==--