From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
cc: Josh berkus <josh@agliodbs.com>, Peter Geoghegan <pg@heroku.com>,
        Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>,
        David Rowley <david.rowley@2ndquadrant.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Magnus Hagander <magnus@hagander.net>,
        Bruce Momjian <bruce@momjian.us>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Rename max_parallel_degree?
In-reply-to: 
 <CAA4eK1J+mSjzoWLXe=azqrLDN9KQqPcf7T5=SKbTFWMZHBS5kA@mail.gmail.com>
References: <20160426152217.GA548975@alvherre.pgsql>
 <CAA4eK1K9jEnnEs_xxR0b5MH_8RTybe22DfkufL=ksX2o-ZqCMw@mail.gmail.com>
 <CAKJS1f_kijB4EPpUrML2q=pourNnQB+WOdBuCCBSDc27BK_gvw@mail.gmail.com>
 <CA+TgmoYjMmSx93onaoOSrWcsNHmD2GOegfyrKoJs=1tbhUMHeg@mail.gmail.com>
 <20160529053300.GD496776@tornado.leadboat.com>
 <CA+TgmoYqLP6dPpcLvWU-ToJFNn4Dp3NE2qAmgXprKN3S6wTSFw@mail.gmail.com>
 <WM!782dde02eb02f131fac86b9aa0affdd2fa2450ae598af9554b103693ecd60442e44967d03f38f3b7cda9ff5b35da9166!@mailstronghold-2.zmailcloud.com>
 <574DBEA4.9000205@agliodbs.com> <8716.1464714201@sss.pgh.pa.us>
 <WM!fa29cdfaada6f23ea036083b3b09c992113c0dd0d39c12a9cb6f842c5da62c7ec3f6f29cf1a792b4d2a344288b7c1492!@mailstronghold-2.zmailcloud.com>
 <574DC585.7010507@agliodbs.com>
 <CAM3SWZR6cd4v-LMmu9hoMR0pRVH9hKPSchEyH=v6BOo7OdhY5Q@mail.gmail.com>
 <WM!4d4bffdc428f6cc6f750204a44dd53cae60035c32efd88a025cf336cd84efaf89a3b03b6e585b4ba6d94b14cd3339b6b!@mailstronghold-3.zmailcloud.com>
 <574DC881.5010006@agliodbs.com> <9816.14647!
 15836@sss.pgh.pa.us> <21146.1464717625@sss.pgh.pa.us>
 <CAA4eK1J+mSjzoWLXe=azqrLDN9KQqPcf7T5=SKbTFWMZHBS5kA@mail.gmail.com>
Comments: In-reply-to Amit Kapila <amit.kapila16@gmail.com>
	message dated "Wed, 01 Jun 2016 15:35:44 +0530"
Date: Wed, 01 Jun 2016 10:10:45 -0400
Message-ID: <17944.1464790245@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Amit Kapila <amit.kapila16@gmail.com> writes:
> Your explanation is clear, however the name max_parallel_workers makes it
> sound like that parallelising an operation is all about workers.  Yes it
> depends a lot on the number of workers allocated for parallel operation,
> but that is not everything.  I think calling it max_parallelism as
> suggested by Alvaro upthread suits better than max_parallel_workers.

I don't think that's a good direction at all.  This entire discussion is
caused by the fact that it's not very clear what "max_parallel_degree"
measures.  Fixing that problem by renaming the variable to something that
doesn't even pretend to tell you what it's counting is not an improvement.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers