Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xS2UG-00000001WzN-0osM for pgsql-hackers@arkaria.postgresql.org; Sat, 14 Nov 2026 01:23:24 +0000 Received: from localhost ([127.0.0.1]:47214 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xS2UE-0000000CYrg-0lim for pgsql-hackers@arkaria.postgresql.org; Sat, 14 Nov 2026 01:23:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:52700) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xS2UD-0000000CYrX-3aaq for pgsql-hackers@lists.postgresql.org; Sat, 14 Nov 2026 01:23:21 +0000 Received: from mail-dl1-x122a.google.com ([2607:f8b0:4864:20::122a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xS2UB-00000000wqs-292z for pgsql-hackers@lists.postgresql.org; Sat, 14 Nov 2026 01:23:21 +0000 Received: by mail-dl1-x122a.google.com with SMTP id a92af1059eb24-1b265399b07so39218c88.0 for ; Fri, 13 Nov 2026 17:23:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794619396; x=1795224196; darn=lists.postgresql.org; h=mime-version:content-transfer-encoding:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DTaPFkC/CkiovL3AN9NJzINAwmwdvpPpCdk0FGaNeOQ=; b=n1EzS+ieXYHGYfhmYNdCCFui54DeFsv0YOfR158Oe06O0d4MI02jhcigr7HaLhhDkU 1chSc8y5cTkZ7r5YgRsEL4cc+Y4nz7jzelOPUdl4IF3u1Ij4MRNPKZckNIZkYlSddCuQ Ql7lg5m5ceYdgcX5FlD9wDpGNtHxOf+M9b+ba26IZjEjZln1Bn2IH9+3bqovaaJubdu8 kx/lY/fbhIi4R0KYuhJ8+lNzMTRnl5HPxNeyyu8WoTT9blzA3rS6swKRNo43vDpmUgO3 2zQXOE1hfaDVu7fqBjjW0ec5WICXuE6Y0Y28Mk7awIM95Dm+U6VCpzFqLXMVrVd/yjVF OTbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794619396; x=1795224196; h=mime-version:content-transfer-encoding:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DTaPFkC/CkiovL3AN9NJzINAwmwdvpPpCdk0FGaNeOQ=; b=U48CCFeriYvNJjl9EieY7aQCNjJnwENrdTLOhsUY2HCrEsAZwJHuAlH0RQiGU6HNxd WrzyAxJzU6Rcwad+JkTm2J3wxNpSPwEa8OvpNhns9c6NtktOSpTct8mVzR2GmbfZSmyo IqMezs66SOiXbYLVoGQMKPWPXVP8To4fTH4Ffn96y+Jn62TBayRCBhtMclG+GML7JXaT lc1Bzcw0M7p3Yck7m2NtdyXwTsSzxxgRdJRalIjzSleHA9XbjsjY7TgvKkQoRjCYA1cM 8Vq2x6oetKcK6qEk2MCA0M/eE+PhmgQxzNvjZWBZCqWyzK4Lc3JkX/TikZwkp5lZ4aU9 cyuA== X-Forwarded-Encrypted: i=1; AL+hErHooh9zut/25fdOBde9S/JEYNkm/AxfRbXVpEJOBxcRaFGtDAfLr03NpJOlK4KNtQUZvPePw8++gBlMbcq4@lists.postgresql.org X-Gm-Message-State: APuU4Z+4QMHqg457H9fnftP5Rravzch2v2dRG1LneR2NUo9GayUXcPA1 fvQ3GcUPjQUL2aoF9pwDCxvQXpYF/4P2BmNhWvU5A3RaR/sj6HswPZ+i X-Gm-Gg: AYBFou3wjYvIIIovijJPPh/rrZY3yKdpxB80m9n8lttc8vdh74uDWIMGIMzsGyETKc0 tsDRiQTJdpFH3QWpzUxmqYAe6GsSwKB6sLT21MyNcxlun44D9+CuBNfxr23HbKxxz/F0GXIUGRl GPbzARWvzMh7jQi1swoc5jMdvveo+oi4KPGhbHRwHXPuDMO4PUzxX17H1RU149YByxJxrIhnGyW DVXg5mqlXA5aJyLG+k60ZAuui3CJOMespfvYa6tPe1Uo3W4De4DxltuV8Cj7gCG/ZBJYthimoWy kwc4iLyC8y50JLzXL50tmx3RD9DTtXUtR80mrkfA0tc2RxOo4auExjVoFFsO7WACg5Jg4JpG7D9 BFFtLX5zS6ShXw66y+UlF7lXvQXrIst10mcTKDMguQZXFO/dv85b6Jcxt0zX/5NIzlBJ35ym1F6 Y1R9t34Hxp/+HvrnqKKUzmlh+JYtvaWaUkYbsq2NVobWjZNbKtEGvkKV1qg7Ajh5ExzHGntyZ8S gPqamuOLPpHT6rQPixz2cbnS+n2JOhdXMCrXQw6woN8+o4BNvESuxD7oxs26xnc71NKnmN4qY2Q VvsaihNyW/WMwZok8PFFciWyRETpDga1d+7eECZFVMhFcbGSeKdgraUfEfGCI2VLmbG1eGrFMHs DvASq1uJK2PEG/lOxMErkCXGRuxYTsupYR8yrH0UzOE38+F+W/siZ1P8= X-Received: by 2002:a05:7022:7f04:b0:1a1:9106:cfff with SMTP id a92af1059eb24-1b503097baamr5964723c88.2.1794619396233; Fri, 13 Nov 2026 17:23:16 -0800 (PST) Received: from 192.168.1.109 ([190.12.171.184]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b50316d9c2sm9783158c88.7.2026.11.13.17.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 17:23:15 -0800 (PST) From: Manu To: Antonin Houska Cc: shihao zhong , pgsql-hackers@lists.postgresql.org Subject: Re: REPACK enhancements Date: Fri, 13 Nov 2026 22:23:07 -0300 Message-ID: <179461938749.1794772.16290685916698475395@gmail.com> In-Reply-To: <309062.1794403598@chrudos> References: <309062.1794403598@chrudos> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Antonin, On Wed, Nov 11, 2026 at 2:26 PM Antonin Houska wrote: > I don't really understand why 'xmax' should be involved. The original > assertion checks exactly whether 'add_to_max' is the "current transaction" = and > I tried to disable it exactly when the function is called by REPACK (to rep= lay > data changes). However, 'xmax' can be invalid even in cases unrelated to > REPACK (i.e. when doing "regular" UPDATE / DELETE). Thus what you propose > makes the assertion a bit less useful. You're right. I used xmax because the replay always gets here with xmax invalid, so the code below never looks at the current transaction. But a regular UPDATE or DELETE usually gets here the same way, so for them the assertion would check nothing, and my "keeps the old check" was wrong. Leaving it commented out, as in v05, is fine with me. Regards, Manu