Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
MIME-Version: 1.0
Message-Id: <17a9104b-9924-4e37-acd7-84761b933f10@app.fastmail.com>
In-Reply-To: 
 <CAA4eK1J4iu3tK=T+9ur6sD6ZXnMQSHGJvHmSpd_badikEWryQw@mail.gmail.com>
References: <20240214.162652.773291409747353211.horikyota.ntt@gmail.com>
 <CAA4eK1J4iu3tK=T+9ur6sD6ZXnMQSHGJvHmSpd_badikEWryQw@mail.gmail.com>
Date: Wed, 14 Feb 2024 11:20:46 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Amit Kapila" <amit.kapila16@gmail.com>,
 "Kyotaro Horiguchi" <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: About a recently-added message
Content-Type: multipart/alternative;
 boundary=8d96a73c7db04a63bf0bf49fdeb93978
Archived-At: <https://www.postgresql.org/message-id/17a9104b-9924-4e37-acd7-84761b933f10%40app.fastmail.com>
Precedence: bulk

--8d96a73c7db04a63bf0bf49fdeb93978
Content-Type: text/plain

On Wed, Feb 14, 2024, at 8:45 AM, Amit Kapila wrote:
> Now, I am less clear about whether to quote "logical" or not in the
> above message. Do you have any suggestions?

The possible confusion comes from the fact that the sentence contains "must be"
in the middle of a comparison expression. For pg_createsubscriber, we are using

        publisher requires wal_level >= logical

I suggest to use something like

        slot synchronization requires wal_level >= logical


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--8d96a73c7db04a63bf0bf49fdeb93978
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Wed, Feb 14,=
 2024, at 8:45 AM, Amit Kapila wrote:<br></div><blockquote type=3D"cite"=
 id=3D"qt" style=3D""><div>Now, I am less clear about whether to quote "=
logical" or not in the<br></div><div>above message. Do you have any sugg=
estions?<br></div></blockquote><div><br></div><div>The possible confusio=
n comes from the fact that the sentence contains "must be"<br></div><div=
>in the middle of a comparison expression. For pg_createsubscriber, we a=
re using<br></div><div><br></div><div>&nbsp; &nbsp; &nbsp; &nbsp; publis=
her requires wal_level &gt;=3D logical<br></div><div><br></div><div>I su=
ggest to use something like<br></div><div><br></div><div>&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;slot synchronization requires wal_level=
 &gt;=3D logical<br></div><div><br></div><div><br></div><div id=3D"sig11=
2409080"><div class=3D"signature">--<br></div><div class=3D"signature">E=
uler Taveira<br></div><div class=3D"signature">EDB&nbsp;&nbsp; <a href=3D=
"https://www.enterprisedb.com/">https://www.enterprisedb.com/</a><br></d=
iv></div><div><br></div></body></html>
--8d96a73c7db04a63bf0bf49fdeb93978--