Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u4QCd-001qoA-6h for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Apr 2025 20:14:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u4QCb-004XXU-0x for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Apr 2025 20:14:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u4QCa-004XXK-Hu for pgsql-hackers@lists.postgresql.org; Mon, 14 Apr 2025 20:14:45 +0000 Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1u4QCX-0005X3-2f for pgsql-hackers@lists.postgresql.org; Mon, 14 Apr 2025 20:14:44 +0000 Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-6eaf1b6ce9aso53201706d6.2 for ; Mon, 14 Apr 2025 13:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1744661680; x=1745266480; darn=lists.postgresql.org; h=in-reply-to:autocrypt:content-language:references:cc:to:from :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=rIPnO0AUf+V73NpVcwk2Yd+eW/tFfDdml2id0w3y+JU=; b=3Wy5Wg1DQq/rH7VjXs7rJEv2ppU660E66uQVEMq7YEL2KWqXBB5ZnUYBEDmtYxCMlH 2LdvgepzJTrSxKUjtLtXvqJbjSWIhma9xSKITGpezM6TrahgLrVGZje5Tr8zGax/oRih M8YVLunPvZBQg8FFwxps10ziGCGRAfXiZePiuvqRtia5f11a/MJ/EykaZ6aLCW1Thitr MyMRJOSCuqzpgiwL396zBFJ8tf7ciU/1N1IWNedF8UVKuSxZTTYN3O2GVNBXBlN6umaW N65097JClFpKqe/nWc6I9xzCYpAfxUGPMCnGvDG+HZeXtR7rxNKYVnxk6kZFI5ZdTD7s P9Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744661680; x=1745266480; h=in-reply-to:autocrypt:content-language:references:cc:to:from :subject:user-agent:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rIPnO0AUf+V73NpVcwk2Yd+eW/tFfDdml2id0w3y+JU=; b=ejDpfSj/nuyICVCBlOJObtqXKHvnOtW32JkO60wlocYLey17OGXmYGc5pHzUe1mk8+ 2kHlFjSYMBHFcTDr+boXIHm0h+JgxDYczrx7cUQy/xGG/oNLLGQMFftsjqGlVsOwzTzb Hh5I5OgboxCfi8ShRSaCXkVTWfcOdZGTLMY70vb1YfyVD+9ot81KQVl/wF9AxdVMrFhN HGD3qBGZZ9yVJ0TfR4/T67MbsR291fxolt91NejULm9exWOxAcn9G8vKrjguGNJIJwLy uXDELkLw6uQp4NdwtM8fxGdngdDJCMHkbqAwFba4tqWYcgUc3s2PTf3AYQuxlz4aHGn+ AjmQ== X-Gm-Message-State: AOJu0YxJaap0721x4/nT0OrFHillpjj6ke1fLelVHIMu5MFcPZOalPKB CVHaQOUSD16x8ULu5LE2zdG4X5XEutdbWhH7N5dyKPb5ntxNp/hqXUm5k+Dy/vU= X-Gm-Gg: ASbGncvh2He8aqPAC5nQwYbr2NVVBBY0LYA8800NkC0gMwctXPWKTR2ZhiXJCzkGHxL yh1K6coydXvXCIJo8iYxxC6jYUQPPXnx8XTy7gLWQ2yil1vKKCMK7d0tmbTM+qXYi0Q0p3650QY S2gMt+fC07D7DLz9S/5ddHc2Sc7/QOaabeUvj5SDytzyVQfbcFM2+qS/EAJt5uZzkK9djPmq+uG c0w3EOQezk4x35wxJE1StB0czvnRv3TywUUJPhpiXTybg2mY4UygL0bY4arkdtujCBAgtAOE26W n7i8HfXdBrmwyHucVdgJ6pqzS3aeqfQedVTyMc+UnjiKSx1V10w0BrheBPE0Jw== X-Google-Smtp-Source: AGHT+IExpnO2Kui/lJyWVm2IAygQSsOOSh65NbDte2V5AEdfzshpBIvARxmkI+QYeZ+5UdxAoVdsqw== X-Received: by 2002:a05:6214:2267:b0:6e8:f8a8:83f2 with SMTP id 6a1803df08f44-6f230cbe0camr178148696d6.6.1744661679830; Mon, 14 Apr 2025 13:14:39 -0700 (PDT) Received: from ?IPV6:2605:a601:a681:6b00::1cb? ([2605:a601:a681:6b00::1cb]) by smtp.googlemail.com with ESMTPSA id 6a1803df08f44-6f0dea07fe8sm87749186d6.80.2025.04.14.13.14.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 13:14:39 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------dqRAtX389FxEFZjXsUMQLJdE" Message-ID: <17b357f9-7a99-4db2-87aa-a16679b52757@dunslane.net> Date: Mon, 14 Apr 2025 16:14:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Non text modes for pg_dumpall, correspondingly change pg_restore From: Andrew Dunstan To: =?UTF-8?Q?=C3=81lvaro_Herrera?= , Mahendra Singh Thalor Cc: pgsql-hackers@lists.postgresql.org References: <202504141220.343fmoxfsbj4@alvherre.pgsql> <6e0e57e5-ace5-4d18-b1c1-7a3b3da36316@dunslane.net> Content-Language: en-US Autocrypt: addr=andrew@dunslane.net; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/ fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw 49QYe1sn2ZPs In-Reply-To: <6e0e57e5-ace5-4d18-b1c1-7a3b3da36316@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------dqRAtX389FxEFZjXsUMQLJdE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-04-14 Mo 12:28 PM, Andrew Dunstan wrote: > > >> >> I'm also not sure about the double sscanf() business there ... There >> must be a better way to do this. > > > > Yes, probably. I'll look into that if you like. > > > something like this? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com --------------dqRAtX389FxEFZjXsUMQLJdE Content-Type: text/x-patch; charset=UTF-8; name="pg_restore-cleanup.patch" Content-Disposition: attachment; filename="pg_restore-cleanup.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3JlLmMgYi9zcmMvYmluL3Bn X2R1bXAvcGdfcmVzdG9yZS5jCmluZGV4IGZmNGJiMzIwZmM5Li5hNjAwZjdkOWEzYiAxMDA2 NDQKLS0tIGEvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYworKysgYi9zcmMvYmluL3Bn X2R1bXAvcGdfcmVzdG9yZS5jCkBAIC0xMDUzLDI2ICsxMDUzLDMyIEBAIGdldF9kYm5hbWVf b2lkX2xpc3RfZnJvbV9tZmlsZShjb25zdCBjaGFyICpkdW1wZGlycGF0aCwgU2ltcGxlT2lk U3RyaW5nTGlzdCAqZGJuCiAJd2hpbGUgKChmZ2V0cyhsaW5lLCBNQVhQR1BBVEgsIHBmaWxl KSkgIT0gTlVMTCkKIAl7CiAJCU9pZAkJCWRiX29pZCA9IEludmFsaWRPaWQ7Ci0JCWNoYXIJ CWRiX29pZF9zdHJbTUFYUEdQQVRIICsgMV0gPSAiIjsKIAkJY2hhcgkgICAqZGJuYW1lOwor CQljaGFyICAgICAgICpwID0gbGluZTsKIAogCQkvKiBFeHRyYWN0IGRib2lkLiAqLwotCQlz c2NhbmYobGluZSwgIiV1IiwgJmRiX29pZCk7Ci0JCXNzY2FuZihsaW5lLCAiJTIwcyIsIGRi X29pZF9zdHIpOworCQl3aGlsZShpc2RpZ2l0KCpwKSkKKwkJCXArKzsKKwkJaWYgKHAgPiBs aW5lICYmICpwID09ICcgJykKKwkJeworCQkJc3NjYW5mKGxpbmUsICIldSIsICZkYl9vaWQp OworCQkJcCsrOworCQl9CiAKIAkJLyogZGJuYW1lIGlzIHRoZSByZXN0IG9mIHRoZSBsaW5l ICovCi0JCWRibmFtZSA9IGxpbmUgKyBzdHJsZW4oZGJfb2lkX3N0cikgKyAxOworCQlkYm5h bWUgPSBwOwogCiAJCS8qIFJlbW92ZSBcbiBmcm9tIGRibmFtZS4gKi8KIAkJZGJuYW1lW3N0 cmxlbihkYm5hbWUpIC0gMV0gPSAnXDAnOwogCi0JCXBnX2xvZ19pbmZvKCJmb3VuZCBkYXRh YmFzZSBcIiVzXCIgKE9JRDogJXUpIGluIFwiJXNcIiIsCi0JCQkJCWRibmFtZSwgZGJfb2lk LCBtYXBfZmlsZV9wYXRoKTsKLQogCQkvKiBSZXBvcnQgZXJyb3IgYW5kIGV4aXQgaWYgdGhl IGZpbGUgaGFzIGFueSBjb3JydXB0ZWQgZGF0YS4gKi8KIAkJaWYgKCFPaWRJc1ZhbGlkKGRi X29pZCkgfHwgc3RybGVuKGRibmFtZSkgPT0gMCkKIAkJCXBnX2ZhdGFsKCJpbnZhbGlkIGVu dHJ5IGluIFwiJXNcIiBhdCBsaW5lIDogJWQiLCBtYXBfZmlsZV9wYXRoLAogCQkJCQkgY291 bnQgKyAxKTsKKwkJZWxzZQorCQkJcGdfbG9nX2luZm8oImZvdW5kIGRhdGFiYXNlIFwiJXNc IiAoT0lEOiAldSkgaW4gXCIlc1wiIiwKKwkJCQkJCWRibmFtZSwgZGJfb2lkLCBtYXBfZmls ZV9wYXRoKTsKKwogCiAJCXNpbXBsZV9vaWRfc3RyaW5nX2xpc3RfYXBwZW5kKGRibmFtZV9v aWRfbGlzdCwgZGJfb2lkLCBkYm5hbWUpOwogCQljb3VudCsrOwo= --------------dqRAtX389FxEFZjXsUMQLJdE--