Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uwkHM-006tSO-QV for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Sep 2025 16:36:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uwkHK-00927x-Ui for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Sep 2025 16:36:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uwkHK-00927g-L0 for pgsql-hackers@lists.postgresql.org; Thu, 11 Sep 2025 16:36:11 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uwkHG-000E6I-21 for pgsql-hackers@postgresql.org; Thu, 11 Sep 2025 16:36:10 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 58BGa46N1802711; Thu, 11 Sep 2025 12:36:04 -0400 From: Tom Lane To: Noah Misch cc: Smolkin Grigory , pgsql-hackers@postgresql.org Subject: Re: race condition in pg_class In-reply-to: <20240512232923.aa.nmisch@google.com> References: <20231027044404.7e.nmisch@google.com> <20231027184832.9b.nmisch@google.com> <1596629.1698435146@sss.pgh.pa.us> <20231027214946.79.nmisch@google.com> <1617596.1698446455@sss.pgh.pa.us> <20231027232612.99.nmisch@google.com> <20231102030915.d3.nmisch@google.com> <20240512232923.aa.nmisch@google.com> Comments: In-reply-to Noah Misch message dated "Sun, 12 May 2024 16:29:23 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1802709.1757608564.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 11 Sep 2025 12:36:04 -0400 Message-ID: <1802710.1757608564@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk [ blast-from-the-past department ] Noah Misch writes: > I'm attaching patches implementing the LockTuple() design. inplace010-tests-v1.patch from this message, committed as 0844b3968, contains this bit: new file mode 100644 index 00000000000..0367c0e37ab --- /dev/null +++ b/src/test/regress/sql/database.sql @@ -0,0 +1,17 @@ +CREATE DATABASE regression_tbd + ENCODING utf8 LC_COLLATE "C" LC_CTYPE "C" TEMPLATE template0; +ALTER DATABASE regression_tbd RENAME TO regression_utf8; +ALTER DATABASE regression_utf8 SET TABLESPACE regress_tblspace; +ALTER DATABASE regression_utf8 RESET TABLESPACE; +ALTER DATABASE regression_utf8 CONNECTION_LIMIT 123; + It emerges that the "ALTER DATABASE regression_utf8 RESET TABLESPACE" command is a complete no-op [1]. I am guessing that that was not the behavior you had in mind, and am wondering if we are losing any test coverage thereby. Did you have a specific reason for manipulating the TABLESPACE property and not some random GUC setting? regards, tom lane [1] https://www.postgresql.org/message-id/flat/30783e-68c28a00-9-41004480%= 40130449754