Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jPQk9-0007cY-HE
	for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Apr 2020 13:09:17 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jPQk7-0006aj-Ds
	for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Apr 2020 13:09:15 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jPQk7-0006ac-7H
	for pgsql-hackers@lists.postgresql.org; Fri, 17 Apr 2020 13:09:15 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jPQjz-0001vu-Oi
	for pgsql-hackers@postgresql.org; Fri, 17 Apr 2020 13:09:14 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 03HD93NQ018035;
	Fri, 17 Apr 2020 09:09:03 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: wrong relkind error messages
In-reply-to: <bbc54d25-d842-9ff8-2cb4-8bb0c0d34af9@2ndquadrant.com>
References: <20200414230208.GA27948@alvherre.pgsql>
 <10405.1586909753@sss.pgh.pa.us>
 <bbc54d25-d842-9ff8-2cb4-8bb0c0d34af9@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Fri, 17 Apr 2020 14:45:34 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18033.1587128943.1@sss.pgh.pa.us>
Date: Fri, 17 Apr 2020 09:09:03 -0400
Message-ID: <18034.1587128943@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2020-04-15 02:15, Tom Lane wrote:
>> In the meantime could we at least say "ALTER TABLE action cannot
>> be performed"?

> We don't know whether ALTER TABLE was the command.  For example, in one 
> of the affected regression test cases, the command is ALTER VIEW.

Maybe just "ALTER action cannot be performed"?  I share Robert's
dislike of being so vague as to just say "action".

			regards, tom lane