Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTmmH-00073o-B8 for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Mar 2022 15:38:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nTmmF-0006QO-Ie for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Mar 2022 15:38:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTmmF-0006QB-9Y for pgsql-hackers@lists.postgresql.org; Mon, 14 Mar 2022 15:38:31 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTmmD-0002ot-5Y for pgsql-hackers@postgresql.org; Mon, 14 Mar 2022 15:38:30 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22EFcNL1180608; Mon, 14 Mar 2022 11:38:23 -0400 From: Tom Lane To: Dmitry Dolgov <9erthalion6@gmail.com> cc: Robert Haas , Zhihong Yu , David Steele , PostgreSQL-development , Greg Stark , Pavel Trukhanov Subject: Re: pg_stat_statements and "IN" conditions In-reply-to: <20220314153346.6chynq26mcypxaco@ddolgov.remote.csb> References: <20210930150957.tz3h3unjyrzatw6e@localhost> <4154685.1641337363@sss.pgh.pa.us> <20220105211111.5oh7ypjfonaqubuq@erthalion.local> <20220310163837.pzvr4yntdk33cbkb@ddolgov.remote.csb> <655954.1646932319@sss.pgh.pa.us> <20220312141030.5panohzsskr4zpkk@erthalion.local> <20220314145734.x3re4hcr6ukmppwi@ddolgov.remote.csb> <178940.1647271397@sss.pgh.pa.us> <20220314153346.6chynq26mcypxaco@ddolgov.remote.csb> Comments: In-reply-to Dmitry Dolgov <9erthalion6@gmail.com> message dated "Mon, 14 Mar 2022 16:33:46 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <180606.1647272303.1@sss.pgh.pa.us> Date: Mon, 14 Mar 2022 11:38:23 -0400 Message-ID: <180607.1647272303@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dmitry Dolgov <9erthalion6@gmail.com> writes: > On Mon, Mar 14, 2022 at 11:23:17AM -0400, Tom Lane wrote: >> I do find it odd that the proposed patch doesn't cause the *entire* >> list to be skipped over. That seems like extra complexity and confusion >> to no benefit. > That's a bit surprising for me, I haven't even thought that folks could > think this is an odd behaviour. As I've mentioned above, the original > idea was to give some clues about what was inside the collapsed array, > but if everyone finds it unnecessary I can of course change it. But if what we're doing is skipping over an all-Consts list, then the individual Consts would be elided from the pg_stat_statements entry anyway, no? All that would remain is information about how many such Consts there were, which is exactly the information you want to drop. regards, tom lane