Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gW3wM-0006Yx-RD
	for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Dec 2018 18:36:31 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gW3wL-0001IP-Fm
	for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Dec 2018 18:36:29 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gW3wL-0001IB-8e
	for pgsql-hackers@lists.postgresql.org; Sun, 09 Dec 2018 18:36:29 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gW3wJ-00021U-9N
	for pgsql-hackers@postgresql.org; Sun, 09 Dec 2018 18:36:28 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wB9IaNvf018076;
	Sun, 9 Dec 2018 13:36:23 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <jcnaylor@gmail.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically assigning catalog toast oids
In-reply-to: 
 <CAJVSVGWjRjY6Kg+sriZitkVVjjH8i4uEyVrQf1bwdu2z61=XLQ@mail.gmail.com>
References: 
 <CAJVSVGWjRjY6Kg+sriZitkVVjjH8i4uEyVrQf1bwdu2z61=XLQ@mail.gmail.com>
Comments: In-reply-to John Naylor <jcnaylor@gmail.com>
	message dated "Sat, 08 Dec 2018 19:57:17 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18074.1544380583.1@sss.pgh.pa.us>
Date: Sun, 09 Dec 2018 13:36:23 -0500
Message-ID: <18075.1544380583@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

John Naylor <jcnaylor@gmail.com> writes:
> Commit 96cdeae07 added toast tables to most catalogs. One disadvantage
> is that the toast declarations require hard-coded oids, even though
> only shared catalogs actually need stable oids. Now that we can assign
> oids on the fly, it makes sense to do so for toast tables as well, as
> in the attached.

I'm a bit dubious that this is a good idea.  It's handy, at least for
forensic situations, that the system catalogs have stable OIDs.

			regards, tom lane