From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Amul Sul <sulamul@gmail.com>, Andres Freund <andres@anarazel.de>,
        Alexander Korotkov <aekorotkov@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        Corey Huinker <corey.huinker@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Joe Conway <mail@joeconway.com>,
        Nikita Glukhov <n.gluhov@postgrespro.ru>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Error-safe user functions
In-reply-to: <0a001cdd-12c9-813d-a8f6-92a8ac48fc80@dunslane.net>
References: <4009543.1670422833@sss.pgh.pa.us>
 <20221208215836.3naznqmal2m32hzc@awork3.anarazel.de>
 <512551.1670540229@sss.pgh.pa.us>
 <20221209023351.l362yejerfoq3lfp@awork3.anarazel.de>
 <633426.1670554790@sss.pgh.pa.us>
 <01ff2051-806d-af2f-4f9e-793f7ba9a3f8@dunslane.net>
 <778369.1670598993@sss.pgh.pa.us>
 <5aaf7c66-9df9-21a9-1ff4-02c7848def52@dunslane.net>
 <3bac9841-fe07-713d-fa42-606c225567d6@dunslane.net>
 <1436686.1670701118@sss.pgh.pa.us>
 <2b1e7d56-6f37-bad9-9702-053ab55ecf60@dunslane.net>
 <1805344.1670779451@sss.pgh.pa.us>
 <b54e97be-7316-2cab-6969-bfac6ec88ca6@dunslane.net>
 <1863335.1670783397@sss.pgh.pa.us> <CAAJ_b951-kZ=FzWpU31A_Lb!
 j6foJmy852T3YeCT6sAqRbqLPWQ@mail.gmail.com>
 <CAAJ_b97KeDWUdpTKGOaFYPv0OicjOu6EW+QYWj-Ywrgj_aEy1g@mail.gmail.com>
 <2687377.1671033604@sss.pgh.pa.us> <be2bb!
 2c4-d246-3cad-b969-7eba4c08336a@dunslane.net>
 <2966981.1671057469@sss.pgh.pa.us>
 <a8dc5700-c341-3ba8-0507-cc09881e6200@dunslane.net>
 <0a001cdd-12c9-813d-a8f6-92a8ac48fc80@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Wed, 21 Dec 2022 18:19:52 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1815580.1671689454.1@sss.pgh.pa.us>
Date: Thu, 22 Dec 2022 01:10:54 -0500
Message-ID: <1815581.1671689454@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1815581.1671689454%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> And here's another for contrib/seg
> I'm planning to commit these two in the next day or so.

I didn't look at the jsonpath one yet.  The seg patch passes
an eyeball check, with one minor nit: in seg_atof,

+	*result = float4in_internal(value, NULL, "real", value, escontext);

don't we want to use "seg" as the type_name?

Even more nitpicky, in

+seg_yyerror(SEG *result, struct Node *escontext, const char *message)
 {
+	if (SOFT_ERROR_OCCURRED(escontext))
+		return;

I'd be inclined to add some explanation, say

+seg_yyerror(SEG *result, struct Node *escontext, const char *message)
 {
+	/* if we already reported an error, don't overwrite it */
+	if (SOFT_ERROR_OCCURRED(escontext))
+		return;

			regards, tom lane