public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Greg Sabino Mullane <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: Corey Huinker <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Cc: jian he <[email protected]>
Subject: Re: Statistics Import and Export
Date: Thu, 22 May 2025 15:41:07 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKAnmmJ5S48AYbf0g+zjni+-mCHqstrE6kULsFFsv1MhuOL5iA@mail.gmail.com>
References: <CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com>
<[email protected]>
<CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com>
<[email protected]>
<CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com>
<y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
<[email protected]>
<CADkLM=eWSv2z_DVB=psfwHitq7DbFJQaP9A46R27eARC-4OYtQ@mail.gmail.com>
<cpdanvzykcb5o64rmapkx6n5gjypoce3y52hff7ocxupgpbxu4@53jmlyvukijo>
<CADkLM=dX67xer59tVYMCQZ+pHAT2sCyyrUDzeDCdW_TdxqwOgA@mail.gmail.com>
<curtrasm6ylt7es2ukfuals2mh5an72yzxgvyel65mw3ere7qs@nw6m4ffpo4m3>
<[email protected]>
<CACJufxHG9MBQozbJQ4JRBcRbUO+t+sx4qLZX092rS_9b4SR_EA@mail.gmail.com>
<CAExHW5vf9D+8-a5_BEX3y=2y_xY9hiCxV1=C+FnxDvfprWvkng@mail.gmail.com>
<[email protected]>
<CAKAnmmKCgnqcd3x! [email protected]>
<CA+Tgmoap_uDKU6K5ch1m=7fiKiEHhbAHWF4EDMhAVG-qdmi=0Q@mail.gmail.com>
<[email protected]>
<CA+TgmoaFpHyW1ZwCjNxJmvCR0NRMLYCkA=O50BCKLGnC1UcJNg@mail.gmail.com>
<[email protected]>
<CA+TgmoYXspGT4dc3jY8B_eJgsT7m=iwqF1i4te3HyG8FdTr1nA@mail.gmail.com>
<CAKAnmmL35eCAX-XoqwFzauaoJekyM5aNQpTaWDU2GvjeChkyog@mail.gmail.com>
<CA+TgmoZ9=RnWcCOZiKYYjZs_AW1P4QXCw--h4dOLLHuf1Omung@mail.gmail.com>
<[email protected]>
<CAKAnmmJ5S48AYbf0g+zjni+-mCHqstrE6kULsFFsv1MhuOL5iA@mail.gmail.com>
Greg Sabino Mullane <[email protected]> writes:
> On Thu, May 22, 2025 at 2:52 PM Jeff Davis <[email protected]> wrote:
>> * The default for pg_restore is --no-statistics. That could cause a minor
>> surprise if the user specifies --with-statistics for pg_dump and
>> not for pg_restore.
> Hm...somewhat to my own surprise, I don't like this. If it's in the dump,
> restore it.
Yeah, I tend to lean that way too. If the user went out of their way
to say --with-statistics for pg_dump, how likely is it that they
don't want the statistics restored?
Another argument pointing in that direction is that the definition
Jeff proposes creates an inconsistency in the output between text
mode:
pg_dump --with-statistics ... | psql
and non-text mode:
pg_dump -Fc --with-statistics ... | pg_restore
There is no additional filter in text mode, so I think pg_restore's
default behavior should also be "no additional filter".
regards, tom lane
view thread (204+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Statistics Import and Export
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox