Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofhn0-00023D-SR for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Oct 2022 13:16:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ofhmy-00019u-RS for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Oct 2022 13:16:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofhmy-00019j-IO for pgsql-hackers@lists.postgresql.org; Tue, 04 Oct 2022 13:16:48 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofhmw-0005Iv-0R for pgsql-hackers@lists.postgresql.org; Tue, 04 Oct 2022 13:16:47 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 294DGiuC1817529; Tue, 4 Oct 2022 09:16:44 -0400 From: Tom Lane To: bt22nakamorit cc: PostgreSQL Hackers Subject: Re: JUMBLE_SIZE macro in two files In-reply-to: References: Comments: In-reply-to bt22nakamorit message dated "Tue, 04 Oct 2022 17:41:12 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1817527.1664889404.1@sss.pgh.pa.us> Date: Tue, 04 Oct 2022 09:16:44 -0400 Message-ID: <1817528.1664889404@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk bt22nakamorit writes: > queryjumble.c and queryjumble.h both define a macro JUMBLE_SIZE = 1024. > Since queryjumble.c includes queryjumble.h, the JUMBLE_SIZE definition > in queryjumble.c should be deleted. I would go more for taking it out of queryjumble.h. I see no reason why that constant needs to be world-visible. regards, tom lane