Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1txdkF-00CRlR-0T for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Mar 2025 03:17:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1txdkD-00FQxl-Hh for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Mar 2025 03:17:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1txdkD-00FQw2-7a for pgsql-hackers@lists.postgresql.org; Thu, 27 Mar 2025 03:17:25 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1txdkB-001RDi-0J for pgsql-hackers@postgresql.org; Thu, 27 Mar 2025 03:17:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 52R3HHhg1818548; Wed, 26 Mar 2025 23:17:17 -0400 From: Tom Lane To: Yurii Rashkovskii cc: Andrei Lepikhov , Euler Taveira , Robert Haas , Michael Paquier , Alexander Korotkov , pgsql-hackers Subject: Re: Add Postgres module info In-reply-to: References: <506788.1733941263@sss.pgh.pa.us> <2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com> <556341.1733967371@sss.pgh.pa.us> <0844622e-9967-409a-8038-470a36f1039c@gmail.com> <8b81a3c0-761f-4cfb-97c6-68819fe4d282@gmail.com> <982748.1734059835@sss.pgh.pa.us> <0e82bf8c-ae70-498d-861e-dba2bb154cad@gmail.com> <29d29c3e-ac9e-48cc-87b4-b1cfd8c2ede8@gmail.com> <992ec366-5c0d-4f23-a02e-30e663613f44@gmail.com> <4476e8cd-6427-4470-98a8-8d61b82d8b1e@gmail.com> <441661.1742683797@sss.pgh.pa.us> <796058.1742757002@sss.pgh.pa.us> <1003653.1742831657@sss.pgh.pa.us> <1085307.1742840674@sss.pgh.pa.us> <1815171.1743043522@sss.pgh.pa.us> Comments: In-reply-to Yurii Rashkovskii message dated "Wed, 26 Mar 2025 19:53:43 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <1818546.1743045437.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Wed, 26 Mar 2025 23:17:17 -0400 Message-ID: <1818547.1743045437@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Yurii Rashkovskii writes: >> Can you propose a specific change to clean it up? I wanted to write >> just "PG_MODULE_MAGIC_DATA()", but I'm not sure that's valid C either. > I was thinking about passing `.name = NULL, .version = NULL` instead of > `0`—do you have any reservations about this? If we're going that way, I'd minimize it to just ".name = NULL". regards, tom lane