From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Julien Rouhaud <rjuju123@gmail.com>,
        Jaime Casanova <jcasanov@systemguards.com.ec>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: SQL-standard function body
In-reply-to: <YG54YggzyPrTFE+e@paquier.xyz>
References: 
 <CAJKUy5j3N23=SuF=S=xX6mu8VX3N9qSbxiej2wMsAqZ3FB2Pow@mail.gmail.com>
 <20210315080344.wed62yy54fuse7jg@nol> <20210315081448.63vagqr3ly45l74i@nol>
 <c17ea953-0837-70ab-b408-522421697d54@2ndquadrant.com>
 <CAJKUy5giffMO31KfBxgSgcaXRC48HfhqwWB6fewAE_8cgOGe2w@mail.gmail.com>
 <20210331101256.d7h7d74o4celskt4@nol>
 <9277ef6a-bfa8-9c06-8e91-16c2892120cc@2ndquadrant.com>
 <20210403033943.dp6um65shvrovoj5@nol>
 <01c65ea6-e5bf-22f4-cacc-6d0f6853a965@2ndquadrant.com>
 <1646498.1617826937@sss.pgh.pa.us> <YG54YggzyPrTFE+e@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 08 Apr 2021 12:28:34 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1819823.1617858962.1@sss.pgh.pa.us>
Date: Thu, 08 Apr 2021 01:16:02 -0400
Message-ID: <1819824.1617858962@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1819824.1617858962%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Apr 07, 2021 at 04:22:17PM -0400, Tom Lane wrote:
>> Buildfarm suggests this has some issues under force_parallel_mode.
>> I'm wondering about missed fields in outfuncs/readfuncs, or the like.

> The problem looks a bit more fundamental to me, as there seems to be
> some confusion with the concept of what should be the query string 
> when it comes to prosqlbody with a parallel run, as it replaces prosrc
> in some cases where the function uses SQL as language.  If the
> buildfarm cannot be put back to green, could it be possible to revert
> this patch?

Andres pushed a stopgap fix.  We might end up reverting the patch
altogether for v14, but I don't want to be hasty.  This should be enough
to let people take advantage of the last few hours before feature freeze.

			regards, tom lane