Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUNQK-0002mI-Kc for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Apr 2021 05:41:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lUNQJ-0007C8-GR for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Apr 2021 05:41:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUNQJ-0007C1-9S for pgsql-hackers@lists.postgresql.org; Thu, 08 Apr 2021 05:41:47 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUNQH-0001GX-96 for pgsql-hackers@lists.postgresql.org; Thu, 08 Apr 2021 05:41:46 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1385fe6J1820955; Thu, 8 Apr 2021 01:41:40 -0400 From: Tom Lane To: Andres Freund cc: Michael Paquier , Peter Eisentraut , Julien Rouhaud , Jaime Casanova , PostgreSQL Hackers Subject: Re: SQL-standard function body In-reply-to: <20210408052759.7bmyawm4djnrux6y@alap3.anarazel.de> References: <20210315081448.63vagqr3ly45l74i@nol> <20210331101256.d7h7d74o4celskt4@nol> <9277ef6a-bfa8-9c06-8e91-16c2892120cc@2ndquadrant.com> <20210403033943.dp6um65shvrovoj5@nol> <01c65ea6-e5bf-22f4-cacc-6d0f6853a965@2ndquadrant.com> <1646498.1617826937@sss.pgh.pa.us> <1819824.1617858962@sss.pgh.pa.us> <20210408052759.7bmyawm4djnrux6y@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 07 Apr 2021 22:27:59 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1820953.1617860500.1@sss.pgh.pa.us> Date: Thu, 08 Apr 2021 01:41:40 -0400 Message-ID: <1820954.1617860500@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > Independent of this patch, it might be a good idea to have > ExecInitParallelPlan() be robust against NULL querystrings. Places like > executor_errposition() are certainly trying to be... FWIW, I think the long-term drift of things is definitely that we want to have the querystring available everywhere. Code like executor_errposition is from an earlier era before we were trying to enforce that. In particular, if the querystring is available in the leader and not the workers, then you will get different error reporting behavior in parallel query than non-parallel query, which is surely a bad thing. So IMO what you did here is definitely a short-term thing that we should be looking to revert. The question at hand is why Peter's patch broke this in the first place, and how hard it will be to fix it properly. I'm entirely on board with reverting the feature if that isn't readily fixable. regards, tom lane