From: Nikolay Shaplov <dhyan@nataraj.su>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Jeff Davis <pgsql@j-davis.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
 Michael Paquier <michael@paquier.xyz>, Amit Langote <amitlangote09@gmail.com>
Subject: Re: [PATCH] New [relation] option engine
Date: Tue, 12 Jul 2022 07:30:40 +0300
Message-ID: <1823308.yXV3o4JbTB@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <72554626ddbb9ff1b8a218139fb2655d9fc5199a.camel@j-davis.com>
References: <3766675.7eaCOWfIcx@thinkpad-pgpro>
 <72554626ddbb9ff1b8a218139fb2655d9fc5199a.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1965751.vWeAYrg2m0";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Archived-At: 
 <https://www.postgresql.org/message-id/1823308.yXV3o4JbTB%40thinkpad-pgpro>
Precedence: bulk

--nextPart1965751.vWeAYrg2m0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Nikolay Shaplov <dhyan@nataraj.su>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jeff Davis <pgsql@j-davis.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, Amit Langote <amitlangote09@gmail.com>
Subject: Re: [PATCH] New [relation] option engine
Date: Tue, 12 Jul 2022 07:30:40 +0300
Message-ID: <1823308.yXV3o4JbTB@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <72554626ddbb9ff1b8a218139fb2655d9fc5199a.camel@j-davis.com>
References: <3766675.7eaCOWfIcx@thinkpad-pgpro> <72554626ddbb9ff1b8a218139fb2655d9fc5199a.camel@j-davis.com>

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D0=BF=D0=BE=D0=BD=
=D0=B5=D0=B4=D0=B5=D0=BB=D1=8C=D0=BD=D0=B8=D0=BA, 11 =D0=B8=D1=8E=D0=BB=D1=
=8F 2022 =D0=B3. 23:03:55 MSK =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=
=B0=D1=82=D0=B5=D0=BB=D1=8C Jeff Davis=20
=D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:

> > For index access methods "amoptions" member function that preformed
> > option
> > processing, were replaced with "amreloptspecset" member function that
> > provided
> > an SpecSet for reloptions for this AM, so caller can trigger option
> > processing
> > himself.
>=20
> What about table access methods? There have been a couple attempts to
> allow custom reloptions for table AMs. Does this patch help that use
> case?

This patch does not add custom reloptions for table AM. It is already huge=
=20
enough, with no extra functionality. But new option engine will make adding=
=20
custom options for table AM more easy task, as main goal of this patch is t=
o=20
simplify adding options everywhere they needed. And yes, adding custom tabl=
e=20
AM options is one of my next goals, as soon as this patch is commit.

=2D-=20
Nikolay Shaplov aka Nataraj
=46uzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

--nextPart1965751.vWeAYrg2m0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE+sk3ebqQKlezKOi8PMbfuIHAGpgFAmLM+PAACgkQPMbfuIHA
Gpg87Af+NTkXtkmTvEwGwZBAYKjLtofBAuPX1kD66pRGsEsm0HiVWpLYlZ4NzgJ6
gkgmgPAHAyAo+EkM4fjRq517D7jii3Kx0TghJG6G7gYHrFAIoSkPzo0msSEQnls9
8H5u4GLFINLt+wzIsWDYxTo3t5ixf3HzJnL+ifQwiGrpIDKt34WATFnKVgRqVqoP
rW8auLZviuodiBZQdnxc9w9weYxWzJwjqKTjl/yLbL+jRCkZqn31HaRGCHHgp7Lf
KvNKChrStXYj8YMum5DTrLD26xMHsmQbAt7dqreMch8E0HJVWkI1eW0OYEEzBydz
JuFrmLo+am2vBafIpGgKVtm+ViTzTA==
=DPsE
-----END PGP SIGNATURE-----

--nextPart1965751.vWeAYrg2m0--