Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fDjO1-0002bT-LG
	for pgsql-hackers@arkaria.postgresql.org; Wed, 02 May 2018 04:29:01 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fDjO0-000663-L9
	for pgsql-hackers@arkaria.postgresql.org; Wed, 02 May 2018 04:29:00 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fDjO0-00065s-AG
	for pgsql-hackers@lists.postgresql.org; Wed, 02 May 2018 04:29:00 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fDjNx-00010C-Rz
	for pgsql-hackers@postgresql.org; Wed, 02 May 2018 04:28:59 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w424SsLT018265;
	Wed, 2 May 2018 00:28:54 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: Michael Paquier <michael@paquier.xyz>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: A few warnings on Windows
In-reply-to: 
 <CAEepm=0xscPGb=VORui=ikec5OJ17t4hJG5KjEJk7B2+wUAJXA@mail.gmail.com>
References: 
 <CAEepm=3=TDYEXUEcHpEx+Twc31wo7PA0oBAiNt6sWmq93MW02A@mail.gmail.com>
 <20180501083026.GB25848@paquier.xyz> <15083.1525207729@sss.pgh.pa.us>
 <CAEepm=2AQxJENLfhZzU-=AcxmHXbDXV=kEdzPh7hjQrmmuHxWQ@mail.gmail.com>
 <CAEepm=3Q9y5mUcheKZ2jC9yFn8jb9Z-5vF03WE0mPD-JskSZVQ@mail.gmail.com>
 <26880.1525217953@sss.pgh.pa.us>
 <CAEepm=1vo7zUaAvHcRnLieNQ2rbqDDoyjDXxWxJF_aUfWCY8Lg@mail.gmail.com>
 <CAEepm=0xscPGb=VORui=ikec5OJ17t4hJG5KjEJk7B2+wUAJXA@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@enterprisedb.com>
	message dated "Wed, 02 May 2018 13:26:17 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18263.1525235334.1@sss.pgh.pa.us>
Date: Wed, 02 May 2018 00:28:54 -0400
Message-ID: <18264.1525235334@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Wed, May 2, 2018 at 12:51 PM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> Perhaps that's what Peter E meant when he said "Windows could use some
>> manual adjustments in pg_config.h.win32 if anyone
>> cares"[1].  Should we just change this to 1?  I'm going to go and test
>> that now.  From googling sizeof(bool) am aware that ancient VC (before
>> 5.0 more than 20 years ago) had a header that defined bool as int, but
>> that seems irrelevant now, right?

> That compiles and runs the main checks (except tablespace which I
> suppress) cleanly for me and I assume it really is using
> stdbool.h this time.  Hopefully plperl will be happier this way.

Pushed.  I was slightly tempted to add a static assertion that
SIZEOF_BOOL == sizeof(bool), but there's not any obvious home
for such a thing, and it's probably just useless worrying anyway.

> Since my earlier test, a new entirely independent warning arrived with
> commit 41c912ca:

Ooops.

> Patch for that attached, too.

Pushed that too, thanks.

			regards, tom lane