From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: pgsql-hackers@lists.postgresql.org, David Rowley <dgrowleyml@gmail.com>
Subject: Recent failures on buildfarm member hornet
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1830490.1601944935.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 05 Oct 2020 20:42:15 -0400
Message-ID: <1830491.1601944935@sss.pgh.pa.us>
Precedence: bulk

hornet has failed its last five runs with

2020-10-05 22:45:42.784 UTC [34734498:40] pg_regress/create_aggregate LOG:=
  statement: create aggregate my_percentile_disc(float8 ORDER BY anyelemen=
t) (
	  stype =3D internal,
	  sfunc =3D ordered_set_transition,
	  finalfunc =3D percentile_disc_final,
	  finalfunc_extra =3D true,
	  finalfunc_modify =3D read_write
	);
TRAP: FailedAssertion("variadicArgType !=3D InvalidOid", File: "pg_aggrega=
te.c", Line: 216, PID: 34734498)

After looking at the commits immediately preceding the first failure, and
digging around in the aggregate-related code, it seems like commit =

cc99baa43 (Improve pg_list.h's linitial(), lsecond() and co macros)
must've broke it somehow.  The nearest thing that I can see to a theory
is that where DefineAggregate does
		numDirectArgs =3D intVal(lsecond(args));
it's coming out with the wrong result, leading to a failure of the
numDirectArgs-vs-numArgs sanity check in AggregateCreate.  But how could
that be?  I hesitate to blame the compiler twice in one week.  OTOH, it's
a not-very-mainstream compiler on a not-very-mainstream architecture.

Noah, can you poke into this in a little more detail and try to verify
what is happening?

			regards, tom lane