Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jGQW1-0004Sk-JW for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Mar 2020 17:05:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jGQW0-0005n4-Ep for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Mar 2020 17:05:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jGQW0-0005mw-67 for pgsql-hackers@lists.postgresql.org; Mon, 23 Mar 2020 17:05:28 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jGQVx-0001gZ-W1 for pgsql-hackers@lists.postgresql.org; Mon, 23 Mar 2020 17:05:27 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 02NH5JV3018328; Mon, 23 Mar 2020 13:05:19 -0400 From: Tom Lane To: Alvaro Herrera cc: James Coleman , Tomas Vondra , Michael Paquier , Rafia Sabih , Peter Geoghegan , Simon Riggs , Shaun Thomas , Dmitry Dolgov <9erthalion6@gmail.com>, Alexander Korotkov , PostgreSQL Developers , andreas@proxel.se Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort) In-reply-to: <20200323164446.GA6911@alvherre.pgsql> References: <20200323164446.GA6911@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Mon, 23 Mar 2020 13:44:46 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <18326.1584983119.1@sss.pgh.pa.us> Date: Mon, 23 Mar 2020 13:05:19 -0400 Message-ID: <18327.1584983119@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > ... all plan types that use only one child use the outer one. They > could use either, as long as it does that consistently, I think. Yeah, exactly. The outer/inner terminology is really only sensible for join nodes, but there isn't a third child-plan pointer reserved for single-child node types, so you gotta use one of those. And conventionally we use the "outer" one. regards, tom lane