Received: from maia.hub.org (maia-5.hub.org [200.46.204.29])
	by mail.postgresql.org (Postfix) with ESMTP id 96622B5D95B
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Thu, 27 Oct 2011 00:36:40 -0300 (ADT)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024)
	with ESMTP id 40483-05
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Thu, 27 Oct 2011 03:36:34 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.8.0-rc2
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id 76681B5D80B
	for <pgsql-hackers@postgresql.org>;
	Thu, 27 Oct 2011 00:36:34 -0300 (ADT)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p9R3aJkw018334;
	Wed, 26 Oct 2011 23:36:19 -0400 (EDT)
To: Robert Haas <robertmhaas@gmail.com>
cc: Simon Riggs <simon@2ndquadrant.com>, Florian Pflug <fgp@phlo.org>,
	Aidan Van Dyk <aidan@highrise.ca>, Daniel Farina <daniel@heroku.com>,
	Chris Redekop <chris@replicon.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Hot Backup with rsync fails at pg_clog if under load 
In-reply-to: 
 <CA+TgmoaJw9TV8CTP0t9R62=JFUb5ye811Wm4sK1M=3LOb+PYsA@mail.gmail.com>
References: 
 <CAC2SuRJTtsXL67EuTdd25GThYZBZTcepfG7Z0Vvv2pZQWzJD=w@mail.gmail.com>
	<CAC2SuRKyt0K35ExCTNnYuf+3XfAjSJJQV_sVX+O4jVTfDuAxog@mail.gmail.com>
	<CAC2SuRJPNqPe7Ga8LT6Q-vOgn05BmiH=y6F_dfiVu5u3NfOs=w@mail.gmail.com>
	<CAAZKuFbUSxOb8x80k9-fD9CsXBRmzTNWutqcDVGaTvwFTvURiQ@mail.gmail.com>
	<213AEFBF-479C-4F9E-B0CA-24AAB2C9F4DD@phlo.org>
	<CA+U5nMJksETN=sJEmu2FqhWNv2Uv63e_9T5OrZEGmviNnWEC5Q@mail.gmail.com>
	<CA+U5nMJfnaay7p_rRzrvWLTyO-aKNEh414czr3jyXT8vhHiJVw@mail.gmail.com>
	<1A94CE1A-C3E5-4923-B677-623D41BC273F@phlo.org>
	<CA+U5nMKUUoA8kRG=itfsO5nZuE3x_KDJz78EaUN3_FKmq-uMJA@mail.gmail.com>
	<6C3D7EDA-573E-46DC-9047-5FEB92876DA8@phlo.org>
	<CA+U5nMJLDZ7VP1O3Jdde+p+9-HxuEi8qG+v5+LuoZGSiOvhkxA@mail.gmail.com>
	<CAC_2qU_eCUYMY6O5CgAK0pYugd=moApirdAt8G_G2sYKs0DfOQ@mail.gmail.com>
	<CA+U5nML+fJgz-NdZrGX+R3m6JKnT1JC=v0iXkkSAsojnsqqPoQ@mail.gmail.com>
	<FD57812A-6A9B-44F3-8CDF-3CD2F8D9918E@phlo.org>
	<12E895D5-C6D0-4E71-B9C3-85E1BC14E6B8@phlo.org>
	<CA+U5nMLyW=S1DTBhswOirf_EZX06epvtyUZN364BGPJBD!
	H_tiA@mail.gmail.com> <CA+U5nM{ h@ L
	<CA+TgmoaJw9TV8CTP0t9R62=JFUb5ye811Wm4sK1M=3LOb+PYsA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 26 Oct 2011 21:32:31 -0400"
Date: Wed, 26 Oct 2011 23:36:19 -0400
Message-ID: <18333.1319686579@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.404 tagged_above=-5 required=5 tests=BAYES_00=-1.9,
	RP_MATCHES_RCVD=-0.504
X-Spam-Level: 
X-Archive-Number: 201110/1425
X-Sequence-Number: 197231

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Oct 26, 2011 at 12:16 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>> This fixes both the subtrans and clog bugs in one patch.

> I don't see the point of changing StartupCLOG() to be an empty
> function and adding a new function TrimCLOG() that does everything
> StartupCLOG() used to do.

+1 ... I found that overly cute also.

			regards, tom lane