From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: Why does pgindent's README say to download typedefs.list from the
 buildfarm?
In-reply-to: 
 <CA+TgmobNVBN=Ki=N_5s__T3fvvaD3ppawjEs6KrQB5jUXBL2pA@mail.gmail.com>
References: <20240422192218.GB367217@nathanxps13>
 <3154983.1713816488@sss.pgh.pa.us> <20240422202010.GA420168@nathanxps13>
 <20240423200455.GA850264@nathanxps13>
 <CA+Tgmoacj1F=h6HQocSo7btsYDE7Sh+9Lz-g=uZpDMFUVMeCjQ@mail.gmail.com>
 <20240515192952.GA1428991@nathanxps13>
 <CA+TgmobNVBN=Ki=N_5s__T3fvvaD3ppawjEs6KrQB5jUXBL2pA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 15 May 2024 16:07:18 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1833481.1715804603.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 15 May 2024 16:23:23 -0400
Message-ID: <1833482.1715804603@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1833482.1715804603%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, May 15, 2024 at 3:30=E2=80=AFPM Nathan Bossart <nathandbossart@g=
mail.com> wrote:
>> This is much cleaner, thanks.  The only thing that stands out to me is =
that
>> the "once per release cycle" section should probably say to do an inden=
t
>> run after downloading the typedef file.

> How's this?

This works for me.  One point that could stand discussion while we're
here is whether the once-a-cycle run should use the verbatim buildfarm
results or it's okay to editorialize on that typedefs list.  I did a
little of the latter in da256a4a7, and I feel like we should either
bless that practice in this document or decide that it was a bad idea.

For reference, what I added to the buildfarm's list was

+InjectionPointCacheEntry
+InjectionPointCondition
+InjectionPointConditionType
+InjectionPointEntry
+InjectionPointSharedState
+NotificationHash
+ReadBuffersFlags
+ResourceOwnerData
+WaitEventExtension
+WalSyncMethod

I believe all of these must have been added manually during v17.
If I took any one of them out there was some visible disimprovement
in pgindent's results, so I kept them.  Was that the right decision?
If so we should explain it here.

			regards, tom lane