Subject: Re: psql - add SHOW_ALL_RESULTS option
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
 <20210412193301.GA11204@alvherre.pgsql> <YHeVHH0wVcRwdogL@paquier.xyz>
 <3738387.1618451507@sss.pgh.pa.us>
 <alpine.DEB.2.22.394.2104151336060.191178@pseudo>
 <451a2111-3757-c511-9413-8f8af531a167@enterprisedb.com>
 <alpine.DEB.2.22.394.2106121130400.4105466@pseudo>
 <CALDaNm0+pzGgp-M1mAoUVYRtjadbWYuB96J8RaV9iH3+HA8FTA@mail.gmail.com>
 <alpine.DEB.2.22.394.2107151742300.1705285@pseudo>
 <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com>
 <alpine.DEB.2.22.394.2107221655020.25741@pseudo>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <183d6be9-7290-9af1-ba88-9c44a5c0d4f8@enterprisedb.com>
Date: Fri, 20 Aug 2021 13:28:10 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2107221655020.25741@pseudo>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/183d6be9-7290-9af1-ba88-9c44a5c0d4f8%40enterprisedb.com>
Precedence: bulk

On 22.07.21 16:58, Fabien COELHO wrote:
> Here is the updated version (v8? I'm not sure what the right count is), 
> which works for me and for "make check", including some tests added for 
> uncovered paths.
> 
> I included your tap test (thanks again!) with some more comments and 
> cleanup.

The tap test had a merge conflict, so I fixed that and committed it 
separately.  I was wondering about its portability, so it's good to sort 
that out separately from your main patch.  There are already a few 
failures on the build farm right now, so let's see where this is heading.