From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Jan Wieck <jan@wi3ck.info>
Subject: Re: I propose killing PL/Tcl's "modules" infrastructure
In-reply-to: 
 <CA+Tgmoa5R2__OLUVm2jLj1NEL3Cj5gZbmkvJPmQXyWQdSZUrEQ@mail.gmail.com>
References: <22067.1488046447@sss.pgh.pa.us>
 <234c68e3-47ee-4db1-fe6d-6a5de56575b6@2ndQuadrant.com>
 <23184.1488048288@sss.pgh.pa.us>
 <33fe0208-74df-1a03-08af-9a4f0d1ed14d@2ndQuadrant.com>
 <24478.1488050485@sss.pgh.pa.us>
 <45faa542-212a-5225-2b62-c80a8df2d0fd@2ndQuadrant.com>
 <18606.1488138882@sss.pgh.pa.us>
 <CA+Tgmoa5R2__OLUVm2jLj1NEL3Cj5gZbmkvJPmQXyWQdSZUrEQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Mon, 27 Feb 2017 12:23:04 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18546.1488199693.1@sss.pgh.pa.us>
Date: Mon, 27 Feb 2017 07:48:13 -0500
Message-ID: <18547.1488199693@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Feb 27, 2017 at 1:24 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> * I'm not terribly comfortable about what the permissions levels of the
>> GUCs ought to be. ... Maybe we'd better make them both SUSET.

> Making them SUSET sounds like a usability fail to me.  I'm not sure
> how bad the security risks of NOT making them SUSET are, but I think
> if we find that SUSET is required for safety then we've squeezed most
> of the value out of the feature.

Well, the feature it's replacing (autoload an "unknown" module) had to be
squeezed down to being effectively superuser-only, so we're not really
losing anything compared to where we are now.  And the more I think about
it, the less I think we can introduce a new security-critical GUC and just
leave it as USERSET.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers