Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebppI-0001Mf-It for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Jan 2018 15:40:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebppH-00038T-NP for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Jan 2018 15:40:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ebppH-00038K-Gm for pgsql-hackers@lists.postgresql.org; Wed, 17 Jan 2018 15:40:31 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ebppE-0001GK-MU for pgsql-hackers@lists.postgresql.org; Wed, 17 Jan 2018 15:40:31 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w0HFeQbB018639; Wed, 17 Jan 2018 10:40:26 -0500 From: Tom Lane To: Victor Wagner cc: pgsql-hackers@lists.postgresql.org Subject: Re: master make check fails on Solaris 10 In-reply-to: <20180117183229.2bbc6eb7@fafnir.local.vm> References: <0d3a9fa264cebe1cb9966f37b7c06e86@postgrespro.ru> <20180111173938.jimybeayp2u5mmup@alap3.anarazel.de> <31a342fa6a025a8bdfc5b8b19c29d56d@postgrespro.ru> <1232.1515780057@sss.pgh.pa.us> <15299.1515867055@sss.pgh.pa.us> <18209.1516059711@sss.pgh.pa.us> <90ab676392c8f9c84431976147097cf0@postgrespro.ru> <16720.1516201657@sss.pgh.pa.us> <20180117183229.2bbc6eb7@fafnir.local.vm> Comments: In-reply-to Victor Wagner message dated "Wed, 17 Jan 2018 18:32:29 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <18637.1516203626.1@sss.pgh.pa.us> Date: Wed, 17 Jan 2018 10:40:26 -0500 Message-ID: <18638.1516203626@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Victor Wagner writes: > On Wed, 17 Jan 2018 10:07:37 -0500 > Tom Lane wrote: >> Yeah, I can work with this. What I propose to do is use a somewhat >> stripped-down version of this test as an AC_RUN_IFELSE test normally, >> but if cross-compiling, fall back to just seeing if we can link. > I'd suggest to add a configure option to switch off 128-bit support > (--disable-int128), especially for these cross-compile cases where link > test cannot give us enough information to decide automatically. I don't want to go there without some evidence that the problem is much more widespread than it appears now. A disable switch will be a permanent documentation and maintenance overhead, plus anyone who puts it into their build scripts will probably never remember to remove it :-(. And how many people will be cross-compiling to Solaris/SPARC anyway? (If there are any, they can always manually change pg_config.h ...) regards, tom lane